[Core] Fix undefined constant ReflectionClassConstant::IS_PUBLIC in php 7.x (#1474)

samsonasik · web-flow · commit 2bde6b32625c · 2021-12-13T12:56:26.000+01:00
diff --git a/src/DependencyInjection/Collector/ConfigureCallValuesCollector.php b/src/DependencyInjection/Collector/ConfigureCallValuesCollector.php
@@ -6,7 +6,6 @@
 
 use Rector\Core\Contract\Rector\ConfigurableRectorInterface;
 use ReflectionClass;
-use ReflectionClassConstant;
 use Symfony\Component\Console\Style\SymfonyStyle;
 use Symfony\Component\DependencyInjection\Definition;
 use Symplify\PackageBuilder\Console\Style\SymfonyStyleFactory;
@@ -68,15 +67,17 @@ private function addConfigureCallValues(string $rectorClass, array $configureVal
                     // fixes bug when 1 item is unwrapped and treated as constant key, without rule having public constant
                     $classReflection = new ReflectionClass($rectorClass);
 
-                    $constantNamesToValues = $classReflection->getConstants(ReflectionClassConstant::IS_PUBLIC);
-                    foreach ($constantNamesToValues as $constantName => $constantValue) {
-                        if ($constantValue === $firstKey) {
-                            $reflectionConstant = $classReflection->getReflectionConstant($constantName);
-                            if ($reflectionConstant === false) {
-                                continue;
-                            }
+                    $reflectionClassConstants = $classReflection->getReflectionConstants();
+                    foreach ($reflectionClassConstants as $reflectionClassConstant) {
+                        if (! $reflectionClassConstant->isPublic()) {
+                            continue;
+                        }
+
+                        $constantValue = $reflectionClassConstant->getValue();
+                        $constantName = $reflectionClassConstant->getName();
 
-                            if (! str_contains((string) $reflectionConstant->getDocComment(), '@deprecated')) {
+                        if ($constantValue === $firstKey) {
+                            if (! str_contains((string) $reflectionClassConstant->getDocComment(), '@deprecated')) {
                                 continue;
                             }
 
