Skip to content

[PHPUnit 10] Fix typo assertObjectHasNotProperty -> assertObjectNotHasProperty#340

Merged
samsonasik merged 1 commit intomainfrom
fix-typo-assert
Jun 22, 2024
Merged

[PHPUnit 10] Fix typo assertObjectHasNotProperty -> assertObjectNotHasProperty#340
samsonasik merged 1 commit intomainfrom
fix-typo-assert

Conversation

@samsonasik
Copy link
Copy Markdown
Member

@samsonasik samsonasik commented Jun 22, 2024 •
edited
Loading

Ref #338 (review)

Before

There was 1 error:

1) CodeIgniter\Config\BaseConfigTest::testEnvironmentOverrides
Error: Call to undefined method CodeIgniter\Config\BaseConfigTest::assertObjectHasNotProperty()

/Users/samsonasik/www/CodeIgniter4/tests/system/Config/BaseConfigTest.php:134

After

➜  CodeIgniter4 git:(develop) ✗ vendor/bin/phpunit tests/system/Config/BaseConfigTest.php
PHPUnit 10.5.24 by Sebastian Bergmann and contributors.

Runtime:       PHP 8.3.4 with PCOV 1.0.11
Configuration: /Users/samsonasik/www/CodeIgniter4/phpunit.xml.dist

..................                                           18 / 18 (100%)

Time: 00:00.317, Memory: 14.00 MB

OK (18 tests, 48 assertions)

Generating code coverage report in Clover XML format ... done [00:00.188]

Generating code coverage report in HTML format ... done [00:00.755]

Ref https://github.com/sebastianbergmann/phpunit/blob/bb24b2746512bc8be5122bb220064df8f8687451/src/Framework/Assert.php#L1052C34-L1052C60

@samsonasik samsonasik mentioned this pull request Jun 22, 2024
Merged
@samsonasik
Copy link
Copy Markdown
Member Author

samsonasik commented Jun 22, 2024

All checks have passed 🎉 @TomasVotruba I am merging it ;)

@samsonasik samsonasik merged commit eff5d58 into main Jun 22, 2024
@samsonasik samsonasik deleted the fix-typo-assert branch June 22, 2024 19:05
@samsonasik samsonasik mentioned this pull request Jun 22, 2024
Merged
5 tasks
@TomasVotruba
Copy link
Copy Markdown
Member

TomasVotruba commented Jun 23, 2024

Thanks :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@samsonasik @TomasVotruba