This will need a failing test case first, so we're sure it's fixed

yes, it works functional use function exists like in #3383, but it cause failure on not exists with auto-import in Rector\Renaming\Tests\Rector\Name\RenameClassRector\FunctionAutoImportNamesParameterTest::test

we may need to replicate Rector\CodingStyle\ClassNameImport\ClassNameImportSkipper::isFoundInUse():

still have 1 error:

1) Rector\CodingStyle\Tests\Rector\Namespace_\ImportFullyQualifiedNamesRector\ImportFullyQualifiedNamesRectorTest::test with data set #14 (Symplify\SmartFileSystem\SmartFileInfo Object (...))
rules/coding-style/tests/Rector/Namespace_/ImportFullyQualifiedNamesRector/Fixture/bootstrap_names.php.inc
Failed asserting that string matches format description.
--- Expected
+++ Actual
@@ @@
 <?php
 
 namespace {
-    use function SomeNamespace\gc_disable;
     function run_me_never()
     {
         // silent deprecations, since we test them
@@ @@
         error_reporting(E_ALL ^ E_DEPRECATED);
 
         // performance boost
-        gc_disable();
+        \SomeNamespace\gc_disable();
     }
 }

/home/runner/work/rector/rector/packages/testing/src/PHPUnit/AbstractRectorTestCase.php:486
/home/runner/work/rector/rector/packages/testing/src/PHPUnit/AbstractRectorTestCase.php:308
/home/runner/work/rector/rector/rules/coding-style/tests/Rector/Namespace_/ImportFullyQualifiedNamesRector/ImportFullyQualifiedNamesRectorTest.php:27

finally fixed 🎉

All checks have passed 🎉 @TomasVotruba it is ready for review.

Still getting the error from #3383 unfortunately. I'll try to debug it now i can see your fix.

@bendavies I tried with rector-functional-php repository and it working ok:

You can use dev-master as in the screenshot.

Thanks @samsonasik .

Definitely doesn't work on another project of mine, using the master version of rector.
I'll look into it.

Just in case it by cache, you can run with --clear-cache:

vendor/bin/rector --clear-cache process

@bendavies To save both yours and ours time, a GitHub repository with failing GitHub Action would be helpful.
That way, we'll see exactly where the problem is. And we all would know if the problem is solved or not.

hi @samsonasik i've replicated the bug again here:
https://github.com/bendavies/rector-functional-php

@TomasVotruba i have tried to reproduce in github actions in that repo but strangely it didn't replicate.

It errors locally to me.
I'd appreciate if someone could try locally.

I'll continue to try and work out why it errors locally for me.

I've also added a stack trace on that repo readme

well, adding

        if (function_exists($classLike)) {
            return true;
        }

to

I think the problem might be here?

Functional\each will do function_exists('each') which is always true, since each is a built in php function

@bendavies I did a lot of simulation in that part :), that's used in rules, that's why that check was needed, could you provide a patch and add a fixture to https://github.com/rectorphp/rector/tree/master/tests/Issues/Issue3383/DoNotReImportFunction/Fixture for reproduce it? thank you.

@bendavies I cloned your repo, re-try run vendor/bin/rector process and it working ok:

That maybe related with cache somewhere, please try clear cache composer as well.

@bendavies you may need to remove vendor first too, as that something-something cache sometime there, remove composer.lock, composer clearcache, remove re-try composer install, and re-run vendor/bin/rector --clear-cache process

That's it, I can't reproduce it by using your repo. If you can provide reproduceable fixture, and provide a fix, that will be awesome ;)

@samsonasik thanks for trying. i'll try to get a reproduced in this repo.