Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

withRootFiles() ignores ".php-cs-fixer.dist.php" #8896

Closed
andrew-demb opened this issue Nov 14, 2024 · 4 comments · Fixed by rectorphp/rector-src#6592
Closed

withRootFiles() ignores ".php-cs-fixer.dist.php" #8896

andrew-demb opened this issue Nov 14, 2024 · 4 comments · Fixed by rectorphp/rector-src#6592
Labels
feature

Comments

@andrew-demb
Copy link

Feature Request

Documentation at [1] states, that using withRootFiles will make sure, that rector will apply rules to the root directory PHP files like a "rector.php", "ecs.php", etc.

But rector doesn't apply rules for ".php-cs-fixer.dist.php" at the root directory for now.

Feature request is: withRootFiles should include hidden PHP files from the root (or at least for well known files like a ".php-cs-fixer.dist.php")

[1] https://getrector.com/documentation/define-paths

Diff

N/A
@TomasVotruba
Copy link
Member

Sounds reasonable. Could you send PR with the fix?

@andrew-demb
Copy link
Author

@TomasVotruba what's the proper way to fix it?

  1. Include any dot-prefixed PHP files
  2. Include just ".php-cs-fixer.dist.php"

@TomasVotruba
Copy link
Member

What would be behavior you'd expect?

andrew-demb added a commit to andrew-demb/rector-src that referenced this issue Dec 15, 2024
@andrew-demb
✨ withRootFiles now apply rector for dotfiles too
7deedc1 
Resolves rectorphp/rector#8896
@andrew-demb andrew-demb mentioned this issue Dec 15, 2024
Merged
@andrew-demb
Copy link
Author

What would be behavior you'd expect?

Include any dot-prefixed PHP files

Here's the PR rectorphp/rector-src#6592

andrew-demb added a commit to andrew-demb/rector-src that referenced this issue Dec 15, 2024
@andrew-demb
✨ withRootFiles now apply rector for dotfiles too
0c6a4cc 
Resolves rectorphp/rector#8896
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

✨ withRootFiles now apply rector for dotfiles too andrew-demb/rector-src
2 participants
@TomasVotruba @andrew-demb