-
-
Notifications
You must be signed in to change notification settings - Fork 738
Missing cases in CompleteDynamicPropertiesRector #6806
Copy link
Copy link
Closed
Labels
Description
Feature Request
I went through the test cases and couldn't find these two.
Diff
- Nothing seems to explicitly address dynamic properties created from outside the class itself. I suspect that there will be plenty of cases where a variable's class can't even be detected, or messed up due to multiple classes of the same name (projects with no autoloading, or mutually-exclusive autoload configs). Executable: https://3v4l.org/HFICt
class A
{
+ private $dynamic;
}
$a = new A();
$a->dynamic = 'xyz';- I don't know whether there's an easy way to track down unserialized classes, but I just wanted to throw that case in here for your consideration. Executable: https://3v4l.org/IOSUB
class A
{
}
$a = new A();
$serialized = serialize($a);
$unserialized = unserialize($serialized);
$unserialized->dynamic = 'xyz';
Reactions are currently unavailable