Updated Rector to commit 31adca84ee3701bbd3e834abf30fd542ee454682

TomasVotruba · TomasVotruba · commit 80f642c77d54 · 2025-12-01T20:24:39.000Z
rectorphp/rector-src@31adca8 [transform] tidy up array dim fetch to method call rector (#7694)
diff --git a/rules/Transform/Rector/ArrayDimFetch/ArrayDimFetchToMethodCallRector.php b/rules/Transform/Rector/ArrayDimFetch/ArrayDimFetchToMethodCallRector.php
@@ -18,6 +18,7 @@
 use PhpParser\NodeVisitor;
 use PHPStan\Type\ObjectType;
 use Rector\Contract\Rector\ConfigurableRectorInterface;
+use Rector\NodeTypeResolver\Node\AttributeKey;
 use Rector\Rector\AbstractRector;
 use Rector\Transform\ValueObject\ArrayDimFetchToMethodCall;
 use Symplify\RuleDocGenerator\ValueObject\CodeSample\ConfiguredCodeSample;
@@ -72,9 +73,13 @@ public function refactor(Node $node)
             if (!$node->var instanceof ArrayDimFetch) {
                 return null;
             }
-            return $this->getMethodCall($node->var, 'set', $node->expr) ?? NodeVisitor::DONT_TRAVERSE_CHILDREN;
+            return $this->createExplicitMethodCall($node->var, 'set', $node->expr);
         }
-        return $this->getMethodCall($node, 'get');
+        // is part of assign, skip
+        if ($node->getAttribute(AttributeKey::IS_BEING_ASSIGNED)) {
+            return null;
+        }
+        return $this->createExplicitMethodCall($node, 'get');
     }
     public function configure(array $configuration): void
     {
@@ -90,7 +95,7 @@ private function handleIsset(Isset_ $isset)
         $exprs = [];
         foreach ($isset->vars as $var) {
             if ($var instanceof ArrayDimFetch) {
-                $methodCall = $this->getMethodCall($var, 'exists');
+                $methodCall = $this->createExplicitMethodCall($var, 'exists');
                 if ($methodCall instanceof MethodCall) {
                     $exprs[] = $methodCall;
                     continue;
@@ -116,7 +121,7 @@ private function handleUnset(Unset_ $unset)
         $stmts = [];
         foreach ($unset->vars as $var) {
             if ($var instanceof ArrayDimFetch) {
-                $methodCall = $this->getMethodCall($var, 'unset');
+                $methodCall = $this->createExplicitMethodCall($var, 'unset');
                 if ($methodCall instanceof MethodCall) {
                     $stmts[] = new Expression($methodCall);
                     continue;
@@ -136,7 +141,7 @@ private function handleUnset(Unset_ $unset)
     /**
      * @param 'get'|'set'|'exists'|'unset' $action
      */
-    private function getMethodCall(ArrayDimFetch $arrayDimFetch, string $action, ?Expr $expr = null): ?MethodCall
+    private function createExplicitMethodCall(ArrayDimFetch $arrayDimFetch, string $action, ?Expr $expr = null): ?MethodCall
     {
         if (!$arrayDimFetch->dim instanceof Node) {
             return null;
diff --git a/src/Application/VersionResolver.php b/src/Application/VersionResolver.php
@@ -19,12 +19,12 @@ final class VersionResolver
      * @api
      * @var string
      */
-    public const PACKAGE_VERSION = '35b9d1c092247fad0873692b34996c5087f9cc1a';
+    public const PACKAGE_VERSION = '31adca84ee3701bbd3e834abf30fd542ee454682';
     /**
      * @api
      * @var string
      */
-    public const RELEASE_DATE = '2025-12-01 16:32:25';
+    public const RELEASE_DATE = '2025-12-01 20:20:58';
     /**
      * @var int
      */
diff --git a/src/Reporting/DeprecatedRulesReporter.php b/src/Reporting/DeprecatedRulesReporter.php
@@ -3,12 +3,12 @@
 declare (strict_types=1);
 namespace Rector\Reporting;
 
-use Rector\PhpParser\Enum\NodeGroup;
 use Rector\Configuration\Deprecation\Contract\DeprecatedInterface;
 use Rector\Configuration\Option;
 use Rector\Configuration\Parameter\SimpleParameterProvider;
 use Rector\Contract\PhpParser\Node\StmtsAwareInterface;
 use Rector\Contract\Rector\RectorInterface;
+use Rector\PhpParser\Enum\NodeGroup;
 use RectorPrefix202512\Symfony\Component\Console\Style\SymfonyStyle;
 final class DeprecatedRulesReporter
 {
