remove PlatformAgnosticAssertions - breaks compatiblity with PHPUnit (#930)

TomasVotruba · web-flow · commit 7dedffe81273 · 2021-09-28T18:19:14.000+02:00
diff --git a/packages/Testing/PHPUnit/AbstractTestCase.php b/packages/Testing/PHPUnit/AbstractTestCase.php
@@ -12,8 +12,6 @@
 
 abstract class AbstractTestCase extends TestCase
 {
-    use PlatformAgnosticAssertions;
-
     /**
      * @var array<string, RectorKernel>
      */
diff --git a/packages/Testing/PHPUnit/PlatformAgnosticAssertions.php b/packages/Testing/PHPUnit/PlatformAgnosticAssertions.php
@@ -10,6 +10,8 @@
 /**
  * Relaxes phpunit assertions to be forgiving about platform issues, like directory-separators or newlines.
  * Mostly required to make assertion work on Windows.
+ *
+ * @note Cannot be used, as it breaks compatibility with PHPUnit 8 and 9 @see https://github.com/rectorphp/rector/issues/6709
  */
 trait PlatformAgnosticAssertions
 {

Original file line number	Diff line number	Diff line change
`@@ -12,8 +12,6 @@`
`12`	`12`
`13`	`13`	`abstract class AbstractTestCase extends TestCase`
`14`	`14`	`{`
`15`		`- use PlatformAgnosticAssertions;`
`16`		`-`
`17`	`15`	`/**`
`18`	`16`	`* @var array<string, RectorKernel>`
`19`	`17`	`*/`
Original file line number	Diff line number	Diff line change
`@@ -10,6 +10,8 @@`
`10`	`10`	`/**`
`11`	`11`	`* Relaxes phpunit assertions to be forgiving about platform issues, like directory-separators or newlines.`
`12`	`12`	`* Mostly required to make assertion work on Windows.`
	`13`	`+ *`
	`14`	`+ * @note Cannot be used, as it breaks compatibility with PHPUnit 8 and 9 @see https://github.com/rectorphp/rector/issues/6709`
`13`	`15`	`*/`
`14`	`16`	`trait PlatformAgnosticAssertions`
`15`	`17`	`{`