change is_a in ObjectTypeComparator

samsonasik · samsonasik · commit 79f8698e6a1c · 2021-03-19T22:14:42.000+07:00
diff --git a/rules/TypeDeclaration/TypeAnalyzer/ObjectTypeComparator.php b/rules/TypeDeclaration/TypeAnalyzer/ObjectTypeComparator.php
@@ -37,7 +37,7 @@ public function isCurrentObjectTypeSubType(Type $currentType, Type $newType): bo
             return false;
         }
 
-        return is_a($currentType->getClassName(), $newType->getClassName(), true);
+        return $newType->isSuperTypeOf($currentType)->yes();
     }
 
     private function isClosure(Type $type): bool

Original file line number	Diff line number	Diff line change
`@@ -37,7 +37,7 @@ public function isCurrentObjectTypeSubType(Type $currentType, Type $newType): bo`
`37`	`37`	`return false;`
`38`	`38`	`}`
`39`	`39`
`40`		`- return is_a($currentType->getClassName(), $newType->getClassName(), true);`
	`40`	`+ return $newType->isSuperTypeOf($currentType)->yes();`
`41`	`41`	`}`
`42`	`42`
`43`	`43`	`private function isClosure(Type $type): bool`