Skip to content

Commit 6e65fef

Browse files
committed
Updated Rector to commit 88648d1e6fe18bcc67ea76ebdc76c1d1e6d1fe6f
rectorphp/rector-src@88648d1 [DeadCode] Skip @param true on native bool type on RemoveUselessParamTagRector (#5798)
1 parent 81fd362 commit 6e65fef

File tree

2 files changed

+11
-4
lines changed

2 files changed

+11
-4
lines changed

rules/DeadCode/PhpDoc/DeadParamTagValueNodeAnalyzer.php

Lines changed: 9 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,7 @@
1010
use PHPStan\PhpDocParser\Ast\Type\IdentifierTypeNode;
1111
use Rector\BetterPhpDocParser\PhpDocManipulator\PhpDocTypeChanger;
1212
use Rector\BetterPhpDocParser\ValueObject\Type\BracketsAwareUnionTypeNode;
13+
use Rector\DeadCode\PhpDoc\Guard\StandaloneTypeRemovalGuard;
1314
use Rector\DeadCode\TypeNodeAnalyzer\GenericTypeNodeAnalyzer;
1415
use Rector\DeadCode\TypeNodeAnalyzer\MixedArrayTypeNodeAnalyzer;
1516
use Rector\NodeNameResolver\NodeNameResolver;
@@ -47,14 +48,20 @@ final class DeadParamTagValueNodeAnalyzer
4748
* @var \Rector\BetterPhpDocParser\PhpDocManipulator\PhpDocTypeChanger
4849
*/
4950
private $phpDocTypeChanger;
50-
public function __construct(NodeNameResolver $nodeNameResolver, TypeComparator $typeComparator, GenericTypeNodeAnalyzer $genericTypeNodeAnalyzer, MixedArrayTypeNodeAnalyzer $mixedArrayTypeNodeAnalyzer, ParamAnalyzer $paramAnalyzer, PhpDocTypeChanger $phpDocTypeChanger)
51+
/**
52+
* @readonly
53+
* @var \Rector\DeadCode\PhpDoc\Guard\StandaloneTypeRemovalGuard
54+
*/
55+
private $standaloneTypeRemovalGuard;
56+
public function __construct(NodeNameResolver $nodeNameResolver, TypeComparator $typeComparator, GenericTypeNodeAnalyzer $genericTypeNodeAnalyzer, MixedArrayTypeNodeAnalyzer $mixedArrayTypeNodeAnalyzer, ParamAnalyzer $paramAnalyzer, PhpDocTypeChanger $phpDocTypeChanger, StandaloneTypeRemovalGuard $standaloneTypeRemovalGuard)
5157
{
5258
$this->nodeNameResolver = $nodeNameResolver;
5359
$this->typeComparator = $typeComparator;
5460
$this->genericTypeNodeAnalyzer = $genericTypeNodeAnalyzer;
5561
$this->mixedArrayTypeNodeAnalyzer = $mixedArrayTypeNodeAnalyzer;
5662
$this->paramAnalyzer = $paramAnalyzer;
5763
$this->phpDocTypeChanger = $phpDocTypeChanger;
64+
$this->standaloneTypeRemovalGuard = $standaloneTypeRemovalGuard;
5865
}
5966
public function isDead(ParamTagValueNode $paramTagValueNode, FunctionLike $functionLike) : bool
6067
{
@@ -78,7 +85,7 @@ public function isDead(ParamTagValueNode $paramTagValueNode, FunctionLike $funct
7885
return \false;
7986
}
8087
if (!$paramTagValueNode->type instanceof BracketsAwareUnionTypeNode) {
81-
return \true;
88+
return $this->standaloneTypeRemovalGuard->isLegal($paramTagValueNode->type, $param->type);
8289
}
8390
return $this->isAllowedBracketAwareUnion($paramTagValueNode->type);
8491
}

src/Application/VersionResolver.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -19,12 +19,12 @@ final class VersionResolver
1919
* @api
2020
* @var string
2121
*/
22-
public const PACKAGE_VERSION = '91ed251a8c450a776ec4b739c735b4bd6f9bf8d5';
22+
public const PACKAGE_VERSION = '88648d1e6fe18bcc67ea76ebdc76c1d1e6d1fe6f';
2323
/**
2424
* @api
2525
* @var string
2626
*/
27-
public const RELEASE_DATE = '2024-04-03 19:11:18';
27+
public const RELEASE_DATE = '2024-04-03 13:36:35';
2828
/**
2929
* @var int
3030
*/

0 commit comments

Comments
 (0)