|
| 1 | +/** |
| 2 | + * Regression test for https://github.com/modelcontextprotocol/typescript-sdk/issues/1468 |
| 3 | + * |
| 4 | + * After MCP initialization completes over stdio, both the client transport and the server |
| 5 | + * transport should expose the negotiated protocol version via a `protocolVersion` getter. |
| 6 | + * |
| 7 | + * - `Client` already calls `transport.setProtocolVersion()` after the handshake, so |
| 8 | + * `StdioClientTransport` merely needs to store and surface that value. |
| 9 | + * - `Server._oninitialize()` now calls `transport.setProtocolVersion?.()`, so |
| 10 | + * `StdioServerTransport` is populated on the server side as well. |
| 11 | + */ |
| 12 | + |
| 13 | +import { Client } from '@modelcontextprotocol/client'; |
| 14 | +import type { JSONRPCMessage, Transport } from '@modelcontextprotocol/core'; |
| 15 | +import { InMemoryTransport, LATEST_PROTOCOL_VERSION } from '@modelcontextprotocol/core'; |
| 16 | +import { McpServer } from '@modelcontextprotocol/server'; |
| 17 | + |
| 18 | +/** A thin wrapper around InMemoryTransport that records setProtocolVersion calls. */ |
| 19 | +function makeVersionRecordingTransport(inner: Transport): Transport & { recordedVersion: string | undefined } { |
| 20 | + let recordedVersion: string | undefined; |
| 21 | + return { |
| 22 | + get recordedVersion() { |
| 23 | + return recordedVersion; |
| 24 | + }, |
| 25 | + get onclose() { |
| 26 | + return inner.onclose; |
| 27 | + }, |
| 28 | + set onclose(v) { |
| 29 | + inner.onclose = v; |
| 30 | + }, |
| 31 | + get onerror() { |
| 32 | + return inner.onerror; |
| 33 | + }, |
| 34 | + set onerror(v) { |
| 35 | + inner.onerror = v; |
| 36 | + }, |
| 37 | + get onmessage() { |
| 38 | + return inner.onmessage; |
| 39 | + }, |
| 40 | + set onmessage(v) { |
| 41 | + inner.onmessage = v; |
| 42 | + }, |
| 43 | + start: () => inner.start(), |
| 44 | + close: () => inner.close(), |
| 45 | + send: (msg: JSONRPCMessage) => inner.send(msg), |
| 46 | + setProtocolVersion(version: string) { |
| 47 | + recordedVersion = version; |
| 48 | + } |
| 49 | + }; |
| 50 | +} |
| 51 | + |
| 52 | +describe('Issue #1468: stdio transports expose negotiated protocol version', () => { |
| 53 | + test('Server calls transport.setProtocolVersion() after initialization', async () => { |
| 54 | + const [rawClient, rawServer] = InMemoryTransport.createLinkedPair(); |
| 55 | + |
| 56 | + const serverTransport = makeVersionRecordingTransport(rawServer); |
| 57 | + const mcpServer = new McpServer({ name: 'test-server', version: '1.0.0' }); |
| 58 | + const client = new Client({ name: 'test-client', version: '1.0.0' }); |
| 59 | + |
| 60 | + expect(serverTransport.recordedVersion).toBeUndefined(); |
| 61 | + |
| 62 | + await Promise.all([client.connect(rawClient), mcpServer.server.connect(serverTransport)]); |
| 63 | + |
| 64 | + expect(serverTransport.recordedVersion).toBe(LATEST_PROTOCOL_VERSION); |
| 65 | + }); |
| 66 | + |
| 67 | + test('Client calls transport.setProtocolVersion() after initialization', async () => { |
| 68 | + const [rawClient, rawServer] = InMemoryTransport.createLinkedPair(); |
| 69 | + |
| 70 | + const clientTransport = makeVersionRecordingTransport(rawClient); |
| 71 | + const mcpServer = new McpServer({ name: 'test-server', version: '1.0.0' }); |
| 72 | + const client = new Client({ name: 'test-client', version: '1.0.0' }); |
| 73 | + |
| 74 | + expect(clientTransport.recordedVersion).toBeUndefined(); |
| 75 | + |
| 76 | + await Promise.all([client.connect(clientTransport), mcpServer.server.connect(rawServer)]); |
| 77 | + |
| 78 | + expect(clientTransport.recordedVersion).toBe(LATEST_PROTOCOL_VERSION); |
| 79 | + }); |
| 80 | +}); |
0 commit comments