You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
fix(Text): retain the final fitting truncation prefix - #8153
When Text overflows with maxLines, the truncation search can return the original overflowing content even though a shorter prefix with an ellipsis fits. The search only saved a result when it found an adjacent fitting/overflowing pair, so a fitting final candidate was lost. For example, with a 30px width and measured widths of 10px for a/b, 80px for W, and 5px for the ellipsis, abW should render as ab….
Keep the last fitting prefix while the binary search advances. This retains the existing search range, already-fitting and scaleToFit guards, grapheme handling, and code-point fallback. It does not change behavior when even the ellipsis cannot fit.
Related Issue
Fixes#8152. This is separate from the broader font/style measurement problem in #4735.
How Has This Been Tested?
The actual Text/Surface component regressions cover the final fitting prefix, a single overflowing glyph or grapheme, word/character wrapping, and the runtime fallback. Seven regressions fail on unchanged production code, with four controls passing; all 110 Text tests pass with this change after npm ci on the current lockfile. Measurement is deterministic in these component tests; this is not browser-font visual evidence.
The normal pre-push gate passes on Node 24.22.2: build, 13 build-output tests, lint (no errors), all 407 unit-test files (18,218 passed, six expected failures, 16 skips, one todo), and all five type-check projects. The successful run used VITEST_MAX_WORKERS=2 to limit contention. Two earlier default-concurrency runs exceeded the unchanged Bar sparsity test's five-second timeout; its isolated nine-test file also passes. No tests or timeouts were changed.
Types of changes
Bug fix (non-breaking change which fixes an issue)
New feature
Breaking change
Checklist
My change requires a change to the documentation.
I have updated the documentation accordingly.
I have added tests to cover my changes.
I have added a storybook story or VR test.
No API change; coverage uses the existing actual-component test setup with controlled measurements.
Summary by CodeRabbit
Bug Fixes
Improved text truncation at line limits so displayed text ends at a fitting word or character boundary, including for graphemes and code points.
Corrected behavior when text already fits, an ellipsis cannot fit, or text scaling is enabled.
Tests
Added coverage for truncation boundaries and fallback behavior when Intl.Segmenter is unavailable.
No actionable comments were generated in the recent review.
Walkthrough
The Text truncation search now retains the last fitting candidate while checking prefixes. New tests cover truncation boundaries, grapheme and code-point handling, ellipsis fit, and scaleToFit.
Changes
Text truncation
Layer / File(s)
Summary
Retain the last fitting prefix src/component/Text.tsx, test/component/Text.searchBound.spec.tsx
The search checks one midpoint at a time, saves fitting results, and searches later prefixes. Tests cover fitting boundaries, word and character wrapping, grapheme and code-point handling, ellipsis fit, and scaleToFit behavior.
recharts/recharts#8117: Defines the character-array search input and ellipsis overflow check used by the truncation search.
recharts/recharts#8133: Adds grapheme segmentation and code-point fallback used by the candidate-prefix tests.
Suggested reviewers: pavelvanecek
Merge Risk: Minimal · up to 1c7de
No merge-blocking risk was identified in the truncation change.
Pre-merge checks: 5
Check name
Status
Explanation
Title check
The title names the Text component fix and the retained final fitting truncation prefix, which matches the main change: calculateWordsByLines now keeps the last fitting prefix during the binary search…
Description check
The description follows the repository template. It explains the bug, the fix, and the linked issue (#8152). It describes the testing in detail, marks the bug fix type, and checks the tests box. Items…
Linked Issues check
Issue #8152 requires the truncation search to retain a fitting final prefix and preserve existing guards and fallback behavior. src/component/Text.tsx now stores each fitting midpoint result and con…
Out of Scope Changes check
The pull request changes only the truncation search in src/component/Text.tsx and adds focused regression tests in test/component/Text.searchBound.spec.tsx. Both changes directly support issue #81…
Docstring Coverage
No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat…
Full details: Title check
Explanation
The title names the Text component fix and the retained final fitting truncation prefix, which matches the main change: calculateWordsByLines now keeps the last fitting prefix during the binary search. It is specific and follows the conventional commit style.
Full details: Description check
Explanation
The description follows the repository template. It explains the bug, the fix, and the linked issue (#8152). It describes the testing in detail, marks the bug fix type, and checks the tests box. Items that remain unchecked or unfilled are the documentation fields, the storybook/VR item, and the Screenshots section, which is optional for this change. The template's 'Motivation and Context' heading is covered by the opening Description paragraph rather than a separate section, and the description does not address the Screenshots heading explicitly.
Full details: Linked Issues check
Explanation
Issue #8152 requires the truncation search to retain a fitting final prefix and preserve existing guards and fallback behavior. src/component/Text.tsx now stores each fitting midpoint result and continues the binary search, so the final fitting candidate is retained. test/component/Text.searchBound.spec.tsx covers the abW case, word and character wrapping, single glyph and grapheme boundaries, the no-Intl.Segmenter fallback, already-fitting text, an interior boundary, an ellipsis that cannot fit, and scaleToFit. The reported verification also covers the full Text test set and the normal build, lint, unit-test, and type-check gates.
Full details: Out of Scope Changes check
Explanation
The pull request changes only the truncation search in src/component/Text.tsx and adds focused regression tests in test/component/Text.searchBound.spec.tsx. Both changes directly support issue #8152. No unrelated implementation, API, documentation, or broader font-measurement work is present.
Full details: Docstring Coverage
Explanation
No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 0 functions across 2 files.
Finishing Touches
Generate unit tests (beta)
Create a new PR
Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Run CodeRabbit Verify to test the changes in this pull request.
Recent review info
Run configuration
Source mode: Auto
Repository: Unavailable
Branch: Unavailable
File: No configuration file from this repository applied
Commit: Unavailable
Layers: Organization UI
Review profile: CHILL
Plan: Advanced
Run ID: cd7f3cf6-3a91-4305-b88f-dba3ba5cb65d
Commits
Reviewing files that changed from the base of the PR and between 17b2d29 and 1c7de35.
Files selected for processing: 2
src/component/Text.tsx
test/component/Text.searchBound.spec.tsx
Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 9 remain after this review.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When
Textoverflows withmaxLines, the truncation search can return the original overflowing content even though a shorter prefix with an ellipsis fits. The search only saved a result when it found an adjacent fitting/overflowing pair, so a fitting final candidate was lost. For example, with a 30px width and measured widths of 10px fora/b, 80px forW, and 5px for the ellipsis,abWshould render asab….Keep the last fitting prefix while the binary search advances. This retains the existing search range, already-fitting and
scaleToFitguards, grapheme handling, and code-point fallback. It does not change behavior when even the ellipsis cannot fit.Related Issue
Fixes #8152. This is separate from the broader font/style measurement problem in #4735.
How Has This Been Tested?
The actual
Text/Surfacecomponent regressions cover the final fitting prefix, a single overflowing glyph or grapheme, word/character wrapping, and the runtime fallback. Seven regressions fail on unchanged production code, with four controls passing; all 110 Text tests pass with this change afternpm cion the current lockfile. Measurement is deterministic in these component tests; this is not browser-font visual evidence.The normal pre-push gate passes on Node 24.22.2: build, 13 build-output tests, lint (no errors), all 407 unit-test files (18,218 passed, six expected failures, 16 skips, one todo), and all five type-check projects. The successful run used
VITEST_MAX_WORKERS=2to limit contention. Two earlier default-concurrency runs exceeded the unchanged Bar sparsity test's five-second timeout; its isolated nine-test file also passes. No tests or timeouts were changed.Types of changes
Checklist
No API change; coverage uses the existing actual-component test setup with controlled measurements.
Summary by CodeRabbit
Intl.Segmenteris unavailable.