Update Legend alignment VR test#7554
Merged
Merged
Conversation
Contributor
WalkthroughThe Legend alignment VR fixture now renders explicit axes, named lines, distinct colors, and direct alignment props. Screenshot coverage is split into default alignment and ChangesLegend alignment visual regression
Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
🧹 Nitpick comments (1)
test-vr/tests/LegendPosition.spec-vr.tsx (1)
10-17: 📐 Maintainability & Code Quality | 🔵 Trivial | 💤 Low valueFix minor grammar in the code comment.
For polish and readability, you can add the missing article "an" before "svg attribute" and capitalize "SVG".
💅 Proposed nitpick fix
test('Legend.align with offset', async ({ mount }) => { /* - * offset doesn't actually do anything because it's svg attribute, but Legend renders as HTML. + * offset doesn't actually do anything because it's an SVG attribute, but Legend renders as HTML. * Test included for completeness anyway */ const component = await mount(<LegendAlignVRTest offset={20} />);🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@test-vr/tests/LegendPosition.spec-vr.tsx` around lines 10 - 17, Update the comment in the Legend.align offset test to add “an” before “SVG attribute” and capitalize “SVG,” without changing the test behavior.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In `@test-vr/tests/LegendPosition.spec-vr.tsx`:
- Around line 10-17: Update the comment in the Legend.align offset test to add
“an” before “SVG attribute” and capitalize “SVG,” without changing the test
behavior.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 16e65712-af58-4028-81be-c1f075813eb5
⛔ Files ignored due to path filters (9)
test-vr/__snapshots__/tests/LegendPosition.spec-vr.tsx-snapshots/Legend-align-1-chromium-linux.pngis excluded by!**/*.pngtest-vr/__snapshots__/tests/LegendPosition.spec-vr.tsx-snapshots/Legend-align-1-firefox-linux.pngis excluded by!**/*.pngtest-vr/__snapshots__/tests/LegendPosition.spec-vr.tsx-snapshots/Legend-align-1-webkit-linux.pngis excluded by!**/*.pngtest-vr/__snapshots__/tests/LegendPosition.spec-vr.tsx-snapshots/Legend-align-with-offset-1-chromium-linux.pngis excluded by!**/*.pngtest-vr/__snapshots__/tests/LegendPosition.spec-vr.tsx-snapshots/Legend-align-with-offset-1-firefox-linux.pngis excluded by!**/*.pngtest-vr/__snapshots__/tests/LegendPosition.spec-vr.tsx-snapshots/Legend-align-with-offset-1-webkit-linux.pngis excluded by!**/*.pngtest-vr/__snapshots__/tests/LegendPosition.spec-vr.tsx-snapshots/Legend-align-without-offset-1-chromium-linux.pngis excluded by!**/*.pngtest-vr/__snapshots__/tests/LegendPosition.spec-vr.tsx-snapshots/Legend-align-without-offset-1-firefox-linux.pngis excluded by!**/*.pngtest-vr/__snapshots__/tests/LegendPosition.spec-vr.tsx-snapshots/Legend-align-without-offset-1-webkit-linux.pngis excluded by!**/*.png
📒 Files selected for processing (2)
test-vr/tests/LegendPosition.spec-vr.tsxtest-vr/tests/LegendPositionComponents.tsx
Bundle ReportBundle size has no change ✅ |
|
Tip All tests passed and all changes approved!🟢 UI Tests: 198 tests unchanged |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7554 +/- ##
=======================================
Coverage 88.19% 88.19%
=======================================
Files 615 615
Lines 14270 14270
Branches 3588 3588
=======================================
Hits 12586 12586
Misses 1494 1494
Partials 190 190 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Contributor
|
Staging Deployment Details
These deployments will remain available for 30 days. |
This was referenced Jul 15, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
VR test only, no other changes
Summary by CodeRabbit