Description

Custom label content (content as element or function, e.g. <YAxis label={<MyLabel />} />) returned early from Label before the position was ever calculated, so it only received viewBox and the passthrough props — never the computed x/y/textAnchor/verticalAnchor the built-in Text label gets. That's the mechanism ckifer described in the issue thread ("does these calculations only if you aren't using a custom component").

This hoists the position calculation above the custom-content branches and merges the computed attributes into the props handed to cloneElement/createElement. It's additive: explicitly passed props still win, the built-in Text path renders exactly as before, and radial polar labels (insideStart/insideEnd/end) are unchanged since their rendering isn't attribute-based.

Two existing specs asserted the exact prop set custom content receives, so they now include the new attributes (Label.spec.tsx, Bar.spec.tsx) — the values they pin down (e.g. center of the viewBox) double as verification that the computed positions are correct.

Related Issue

Fixes #5067

Motivation and Context

Custom labels currently have to re-derive their own position from viewBox, duplicating logic recharts already has, and axis labels in particular land at (0,0)/unpositioned. With this change a custom label can just use props.x/props.y like the built-in label does.

How Has This Been Tested?

New regression test rendering <YAxis label={<CustomLabel />} /> in a LineChart and asserting the custom element receives numeric x/y — fails on current main, passes with this change. Updated prop-set assertions in Label.spec.tsx (6 sites) and Bar.spec.tsx also fail on main and pass now. Full Label, LabelList and Bar suites pass (165 tests), plus tsc and eslint on the changed files; the rest of the unit suite matches the baseline.

Screenshots (if appropriate):

n/a — no visual change for built-in labels; custom labels keep rendering whatever they render, they just receive more props.

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

• My change requires a change to the documentation.
• I have updated the documentation accordingly.
• I have added tests to cover my changes.
• I have added a storybook story or VR test, or extended an existing story or VR test to show my changes

Summary by CodeRabbit

• Bug Fixes
  • Improved label positioning across polar and cartesian charts.
  • Prevented labels from rendering when required positioning data is unavailable.
  • Fixed radial labels so they render correctly in supported polar positions.
  • Content callbacks now receive accurate x and y coordinates.
  • Custom Y-axis label elements now receive computed coordinates consistently.