Skip to content

Refresh ScatterChartPerformance example#7493

Merged
PavelVanecek merged 1 commit into
mainfrom
scatter-perf-example
Jun 24, 2026
Merged

Refresh ScatterChartPerformance example#7493
PavelVanecek merged 1 commit into
mainfrom
scatter-perf-example

Conversation

@PavelVanecek

@PavelVanecek PavelVanecek commented Jun 23, 2026 •
edited by coderabbitai Bot
Loading

Copy link
Copy Markdown
Collaborator

Description

Example only, so that we have some baseline for Scatter perf optimizations.

Here are some baseline observations on my laptop and 1k data points:

Initial render:
image

image

Mouse over
image

image

Related Issue

#2862

Summary by CodeRabbit

  • New Features

    • Enhanced scatter chart performance example to demonstrate 3D-scatter visualization with Z-axis support and parameterized dataset generation.

  • Documentation

    • Added descriptive guidance to the scatter chart performance example with instructions for editing data points and observing performance impact.

@PavelVanecek PavelVanecek mentioned this pull request Jun 23, 2026
Merged
5 tasks
@coderabbitai

coderabbitai Bot commented Jun 23, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 27d5fe56-6cf6-49c1-844d-2bc0e6d318a5

📥 Commits

Reviewing files that changed from the base of the PR and between 8c1cce7 and 59151a8.

📒 Files selected for processing (2)
  • www/src/docs/exampleComponents/ScatterChart/ScatterChartPerformance.tsx
  • www/src/docs/exampleComponents/ScatterChart/index.tsx

Walkthrough

The ScatterChartPerformance example is refactored to generate a parameterized synthetic dataset controlled by countOfScatterElements and pointsPerScatter, with each point now including a z coordinate. The chart gains a ZAxis and iterates over datasets when rendering Scatter series. A description field is added to the example's registry entry.

Changes

ScatterChart Performance Example

Layer / File(s) Summary
Parameterized 3D dataset, chart update, and example description
www/src/docs/exampleComponents/ScatterChart/ScatterChartPerformance.tsx, www/src/docs/exampleComponents/ScatterChart/index.tsx		 Replaces the fixed chartData structure with a datasets array parameterized by countOfScatterElements and pointsPerScatter; each point gains a z field. The chart adds ZAxis with dataKey="z" and iterates over datasets to render Scatter series. The example registry entry gains a JSX description explaining the rendering and performance interaction.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title 'Refresh ScatterChartPerformance example' clearly and concisely describes the main change, which is updating the ScatterChartPerformance example component.
Description check ✅ Passed The description includes context about why the change was made and related performance measurements, but lacks several template sections including motivation details, testing methodology, and changelog checklist.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch scatter-perf-example

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@codecov

codecov Bot commented Jun 23, 2026

Copy link
Copy Markdown

Bundle Report

Bundle size has no change ✅

@chromatic-com

chromatic-com Bot commented Jun 23, 2026 •
edited
Loading

Copy link
Copy Markdown

Tip

All tests passed and all changes approved!

🟢 UI Tests: 198 tests unchanged
🟢 UI Review: 198 stories published -- no changes
Storybook icon Storybook Publish: 198 stories published

@codecov

codecov Bot commented Jun 23, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 88.09%. Comparing base (8c1cce7) to head (59151a8).

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #7493   +/-   ##
=======================================
  Coverage   88.09%   88.09%           
=======================================
  Files         606      606           
  Lines       14084    14087    +3     
  Branches     3534     3534           
=======================================
+ Hits        12407    12410    +3     
  Misses       1488     1488           
  Partials      189      189

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions

github-actions Bot commented Jun 23, 2026

Copy link
Copy Markdown
Contributor

Staging Deployment Details

These deployments will remain available for 30 days.

@PavelVanecek
PavelVanecek merged commit d5e55e6 into main Jun 24, 2026
65 checks passed
@PavelVanecek
PavelVanecek deleted the scatter-perf-example branch June 24, 2026 00:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@PavelVanecek