src/chart/Sankey.tsx (1)

521-538: 💤 Low value

Consider: backward pass may push nodes into obstacles above.

When the backward pass shifts nodes up to fit within height, it doesn't re-verify collision with fixed obstacles positioned above the shifted node. In edge cases with multiple stacked obstacles and constrained height, a node could end up overlapping an obstacle.

For the scoped fix targeting "fully contained" nodes (issue #5559), this is likely acceptable since such complex configurations are rare. If broader collision handling is needed later, consider iterating until stable or using a constraint solver.

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@src/chart/Sankey.tsx` around lines 521 - 538, The backward pass loop
iterating from items.length - 1 to 0 shifts nodes upward to fit within the
height constraint, but it does not re-verify collision with fixed obstacles
positioned above the shifted node. To fully address this, you would need to
check each shifted node against all fixed obstacles above it, or implement an
iterative approach that repeats until the layout stabilizes, or use a constraint
solver. However, since this fix is scoped to "fully contained" nodes per issue
`#5559` where such complex stacked configurations are rare, add a code comment
near the dy calculation in the backward pass loop documenting this known
limitation so future maintainers understand the collision handling scope.

test/chart/Sankey.spec.tsx (1)

27-55: 💤 Low value

Consider validating coordinate array length for clearer test failures.

If the SVG path format changes or is malformed, the destructuring will produce undefined values leading to NaN calculations. Adding a guard would provide a clearer error message:

🛡️ Optional defensive check

   if (coordinates == null) {
     throw new Error('Expected Sankey link path to have coordinates');
   }
+
+  if (coordinates.length < 8) {
+    throw new Error(`Expected Sankey link path to have at least 8 coordinates, got ${coordinates.length}`);
+  }

   const [sourceX, sourceY, sourceControlX, sourceControlY, targetControlX, targetControlY, targetX, targetY] =

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@test/chart/Sankey.spec.tsx` around lines 27 - 55, The getLinkYAtX function
validates that coordinates exist but does not validate that the coordinates
array has the expected length of 8 elements. If the SVG path format changes or
is malformed, the destructuring will silently assign undefined values leading to
NaN calculations. Add a length check after the null check to ensure the
coordinates array contains exactly 8 elements, and throw a descriptive error if
it does not, improving the clarity of test failures when the path format is
unexpected.