Skip to content

style: update layout gaps and add new navigation links#7412

Merged
PavelVanecek merged 2 commits into
mainfrom
links
Jun 6, 2026
Merged

style: update layout gaps and add new navigation links#7412
PavelVanecek merged 2 commits into
mainfrom
links

Conversation

@PavelVanecek

@PavelVanecek PavelVanecek commented Jun 6, 2026 •
edited by coderabbitai Bot
Loading

Copy link
Copy Markdown
Collaborator

I added link to npm repository because that's a popular target, and added link to 3.0 migration because I want more people to migrate to 3.0

Summary by CodeRabbit

  • New Features

    • Added npm package registry link to the main navigation menu
    • Added version 3.0 migration guide link to the main navigation menu

  • Style

    • Navigation items now feature responsive spacing that dynamically adjusts based on viewport width
    • Logo padding styling has been updated to use responsive viewport-based values for flexible layout

@coderabbitai

coderabbitai Bot commented Jun 6, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Review Change Stack

Important

Review skipped

Review was skipped due to path filters

⛔ Files ignored due to path filters (3)
  • test-vr/__snapshots__/tests/www/dark-mode.spec-vr.tsx-snapshots/dark-mode-examples-list-1-chromium-linux.png is excluded by !**/*.png
  • test-vr/__snapshots__/tests/www/dark-mode.spec-vr.tsx-snapshots/dark-mode-examples-list-1-firefox-linux.png is excluded by !**/*.png
  • test-vr/__snapshots__/tests/www/dark-mode.spec-vr.tsx-snapshots/dark-mode-examples-list-1-webkit-linux.png is excluded by !**/*.png

CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including **/dist/** will override the default block on the dist directory, by removing the pattern from both the lists.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 4c7f673e-974a-43de-af6a-022d2decea4e

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Walkthrough

This PR updates the website's navigation header with responsive CSS spacing adjustments and adds two new external navigation links. Navigation item spacing now scales responsively, logo padding becomes viewport-relative, and npm and 3.0 migration guide links are added to the navigation menu.

Changes

Navigation Header Enhancement

Layer / File(s) Summary
Responsive navigation layout and new navigation links
www/src/components/navigation.css, www/src/layouts/frame.css, www/src/navigation.ts		 Navigation items gap changes from fixed 40px to responsive min(40px, 2vw) for desktop breakpoints. Logo horizontal padding shifts from symmetric 0 2rem to left-only padding-left: 2vw. Two new top-level navigation entries are added: external npm link and 3.0 migration guide link, both configured to open in new tabs.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

🚥 Pre-merge checks | ✅ 3 | ❌ 2

❌ Failed checks (2 warnings)

Check name Status Explanation Resolution
Description check ⚠️ Warning The description is minimal and lacks required template sections including Related Issue, Motivation and Context, Testing details, Types of changes, and Checklist items. Expand the description to include: related issue link, motivation for the changes, testing approach, type of change classification, and completed checklist items per the repository template.
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately describes the main changes: CSS layout gap updates and addition of new navigation links, covering both the CSS modifications and navigation.ts changes.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch links

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@codecov

codecov Bot commented Jun 6, 2026

Copy link
Copy Markdown

Bundle Report

Bundle size has no change ✅

@chromatic-com

chromatic-com Bot commented Jun 6, 2026 •
edited
Loading

Copy link
Copy Markdown

Tip

All tests passed and all changes approved!

🟢 UI Tests: 198 tests unchanged
🟢 UI Review: 198 stories published -- no changes
Storybook icon Storybook Publish: 198 stories published

@codecov

codecov Bot commented Jun 6, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 88.27%. Comparing base (c393d67) to head (10a83f4).

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #7412   +/-   ##
=======================================
  Coverage   88.27%   88.27%           
=======================================
  Files         607      607           
  Lines       14124    14124           
  Branches     3549     3549           
=======================================
  Hits        12468    12468           
  Misses       1469     1469           
  Partials      187      187

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions

github-actions Bot commented Jun 6, 2026

Copy link
Copy Markdown
Contributor

Staging Deployment Details

These deployments will remain available for 30 days.

To update snapshots: Comment /update-snapshots on this PR to automatically update the baseline screenshots.

@PavelVanecek

PavelVanecek commented Jun 6, 2026

Copy link
Copy Markdown
Collaborator Author

/update-snapshots

@github-actions

github-actions Bot commented Jun 6, 2026

Copy link
Copy Markdown
Contributor

✅ Visual regression snapshots have been updated and committed to this PR.

@PavelVanecek
PavelVanecek merged commit 2921961 into main Jun 6, 2026
4 checks passed
@PavelVanecek
PavelVanecek deleted the links branch June 6, 2026 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@PavelVanecek