Remove our custom storybook plugins#7382
Merged
Merged
Conversation
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (2)
📒 Files selected for processing (147)
💤 Files with no reviewable changes (138)
WalkthroughThis PR systematically removes two local Storybook addons ( ChangesStorybook Addon Removal
Estimated code review effort🎯 4 (Complex) | ⏱️ ~60 minutes The diff is large (1000+ files touched) but homogeneous: it consists of the same removal pattern (delete import and JSX element) applied across 150+ story files, followed by complete deletion of the addon implementation directories. The repetitive nature reduces complexity per file, but the quantity and need to verify all usages are removed requires careful review of the systematic cleanup. Possibly related PRs
Suggested labels
Suggested reviewers
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
|
Bundle ReportBundle size has no change ✅ |
|
Important Visual changes need review - Review now🟢 UI Tests: 4 changes accepted as baselines |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7382 +/- ##
=======================================
Coverage 89.05% 89.05%
=======================================
Files 548 548
Lines 40577 40577
Branches 5581 5581
=======================================
Hits 36136 36136
Misses 4432 4432
Partials 9 9 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
|
Staging Deployment Details
These deployments will remain available for 30 days. To update snapshots: Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These two are blocking update to storybook 10, and we have better alternatives on the website anyway. Let's remove.
Summary by CodeRabbit