test/cartesian/YAxis/YAxis.7362.spec.tsx (2)

44-57: 💤 Low value

Consider advancing timers after rendering.

As per coding guidelines for test files, vi.runOnlyPendingTimers() should be called after renders when not using the createSelectorTestCase helper to account for Redux autoBatchEnhancer delays. While the tests currently pass (animations are disabled), adding timer advancement would align with best practices and make the tests more robust.

⏱️ Suggested pattern

 const renderResult = render(
   <LineChart width={500} height={300} data={data}>
     <XAxis dataKey="name" />
     <YAxis
       type="number"
       domain={explicitDomain}
       allowDataOverflow
       {...(ticks != null ? { ticks } : {})}
       {...(tickCount != null ? { tickCount } : {})}
     />
     <Line type="monotone" dataKey="value" stroke="`#8884d8`" isAnimationActive={false} connectNulls />
     <ExpectAxisDomain assert={axisDomainSpy} axisType="yAxis" />
   </LineChart>,
 );
+vi.runOnlyPendingTimers();

 return {

As per coding guidelines: "Call vi.runOnlyPendingTimers() to advance timers after renders when not using createSelectorTestCase helper."

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@test/cartesian/YAxis/YAxis.7362.spec.tsx` around lines 44 - 57, After the
LineChart render in the test (the render(...) call that assigns renderResult),
advance fake timers by calling vi.runOnlyPendingTimers() immediately after
rendering to account for Redux autoBatchEnhancer delays; locate the render
invocation in YAxis.7362.spec.tsx (the block creating LineChart with
XAxis/YAxis/Line/ExpectAxisDomain) and insert a vi.runOnlyPendingTimers() call
right after it.

---

11-31: 💤 Low value

Minor code duplication across test suites.

The Datum type, explicitDomain, explicitTicks, and test data constants are duplicated between this unit test file and the VR test suite. While the duplication is minor and the tests serve different purposes, consider whether the shared Datum type from Issue7362Chart.tsx could be imported here to reduce maintenance burden.

♻️ Optional: import shared type

+import type { Datum } from '../../test-vr/tests/Issue7362Chart';
 import { ExpectAxisDomain, expectYAxisTicks } from '../../helper/expectAxisTicks';
 import { expectLastCalledWith } from '../../helper/expectLastCalledWith';

-type Datum = {
-  name: string;
-  value: number | null;
-};
-
 const explicitDomain = [0, 100] as const;

Note: The data constants and render helper likely need to remain separate due to the ExpectAxisDomain spy requirement in unit tests.

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@test/cartesian/YAxis/YAxis.7362.spec.tsx` around lines 11 - 31, Replace the
duplicated Datum type by importing the shared Datum type from Issue7362Chart.tsx
and remove the local Datum declaration; keep the existing explicitDomain,
explicitTicks, allNullData, and partlyNumericData constants in this test file
(they must remain local for the ExpectAxisDomain spy), but update their type
annotations to use the imported Datum type so you avoid duplication while
preserving test-local data and helpers.