Remove Area.baseLine type#7317
Merged
Merged
Conversation
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (15)
📒 Files selected for processing (5)
WalkthroughThis PR updates Area and AreaChart components' public API documentation to clarify ChangesArea baseValue Documentation and Visual Regression Tests
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Bundle ReportBundle size has no change ✅ |
|
Tip All tests passed and all changes approved!🟢 UI Tests: 193 tests unchanged |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7317 +/- ##
=======================================
Coverage 88.99% 88.99%
=======================================
Files 541 541
Lines 41136 41136
Branches 5568 5569 +1
=======================================
Hits 36610 36610
Misses 4518 4518
Partials 8 8 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
|
Staging Deployment Details
These deployments will remain available for 30 days. To update snapshots: Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This property was internal in 2.x and unused in 3.x so I removed the type definition. The intended public prop is
baseValueAlso added VR tests for different baseValue combinations.
Motivation and Context
I am making some changes in the animations branch and want this to be covered by screenshots
Types of changes
Checklist:
Summary by CodeRabbit
Release Notes
Breaking Changes
baseLineprop tobaseValuein the Area component for improved clarity.Updates
baseValuebehavior documentation: it now explicitly explains how it configures baseline values for non-stacked, non-ranged areas and reads from the evaluated axis domain.Tests
baseValueconfigurations.