Export and document interpolate function#7293
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (3)
WalkthroughAdds a numeric-only ChangesInterpolate public API, implementation signatures, docs, bundling, and tests
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Review rate limit: 7/8 reviews remaining, refill in 7 minutes and 30 seconds.Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@src/util/DataUtils.ts`:
- Around line 111-122: Update the JSDoc for the interpolation function in
src/util/DataUtils.ts (the function named interpolate or interpolateNumber) to
correct grammar and accurately state the contract: change “between two number”
to “between two numbers,” clarify that if either start or end is not a number
the function returns the end value, and explicitly note that the parameter t is
a numeric interpolation factor that is not clamped by the function (it accepts
values outside 0–1 if caller provides them). Mention callers should clamp t if
they need it.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: d7a0258d-1826-4340-83d1-ea65ed7032f1
📒 Files selected for processing (6)
omnidoc/verifyExamples.spec.tssrc/index.tssrc/util/DataUtils.tswww/src/docs/apiCates.tswww/src/locale/en-US.tswww/src/locale/zh-CN.ts
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #7293 +/- ##
=======================================
Coverage 89.05% 89.05%
=======================================
Files 541 541
Lines 41088 41101 +13
Branches 5564 5565 +1
=======================================
+ Hits 36589 36601 +12
- Misses 4491 4492 +1
Partials 8 8 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Staging Deployment Details
These deployments will remain available for 30 days. To update snapshots: Comment |
|
Staging Deployment Details
These deployments will remain available for 30 days. To update snapshots: Comment |
|
Staging Deployment Details
These deployments will remain available for 30 days. To update snapshots: Comment |
Description
This function is useful for writing custom animations. So let's export it for 3.9
Related Issue
#7215
Types of changes
Checklist:
Summary by CodeRabbit
New Features
Documentation
Bug Fixes
Tests
Chores