Skip to content

fix(Scatter): use HTTPS in JSDoc links#7192

Merged
PavelVanecek merged 1 commit into
recharts:mainfrom
Parth10P:fix/scatter-https-links
Mar 30, 2026
Merged

fix(Scatter): use HTTPS in JSDoc links#7192
PavelVanecek merged 1 commit into
recharts:mainfrom
Parth10P:fix/scatter-https-links

Conversation

@Parth10P

@Parth10P Parth10P commented Mar 30, 2026 •
edited by coderabbitai Bot
Loading

Copy link
Copy Markdown
Contributor

Description

Replace insecure HTTP links with HTTPS in Scatter component JSDoc comments.

Changes

  • src/cartesian/Scatter.tsx: Updated 3 @see documentation links from http:// to https://
Line Prop Link
222 lineType JointLineScatterChart example
232 lineJointType JointLineScatterChart example
256 activeShape SimpleScatterChart example

Why

Documentation links should use HTTPS for security and consistency with the rest of the codebase.

Summary by CodeRabbit

  • Documentation
    • Updated documentation reference links to use secure HTTPS protocol for improved security and consistency.

@Parth10P
fix(Scatter): use HTTPS in JSDoc links
74ea037 
  Replace http:// with https:// in 3 @see documentation links.
@coderabbitai

coderabbitai Bot commented Mar 30, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 8b366330-b729-4232-85d3-9363194152cb

📥 Commits

Reviewing files that changed from the base of the PR and between 43fb99d and 74ea037.

📒 Files selected for processing (1)
  • src/cartesian/Scatter.tsx

Walkthrough

Updated JSDoc @see example links in src/cartesian/Scatter.tsx from HTTP to HTTPS for three prop documentation sections. No runtime logic, types, or exported API signatures were modified.

Changes

Cohort / File(s) Summary
Documentation Links
src/cartesian/Scatter.tsx		 Updated JSDoc @see URLs from http://recharts.github.io/... to https://recharts.github.io/... for lineType, lineJointType, and activeShape prop examples.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Suggested reviewers

  • ckifer
🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately describes the main change: replacing HTTP with HTTPS in JSDoc links within the Scatter component.
Description check ✅ Passed The description provides a clear summary of changes with a detailed table and rationale, but is missing several required template sections like Related Issue, Motivation and Context, How Has This Been Tested, and Types of changes checkboxes.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@codecov

codecov Bot commented Mar 30, 2026 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.06%. Comparing base (43fb99d) to head (74ea037).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #7192   +/-   ##
=======================================
  Coverage   89.06%   89.06%           
=======================================
  Files         539      539           
  Lines       41011    41011           
  Branches     5553     5553           
=======================================
  Hits        36527    36527           
  Misses       4476     4476           
  Partials        8        8

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@codecov

codecov Bot commented Mar 30, 2026

Copy link
Copy Markdown

Bundle Report

Bundle size has no change ✅

@PavelVanecek
PavelVanecek merged commit 4adda8c into recharts:main Mar 30, 2026
52 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@PavelVanecek PavelVanecek PavelVanecek approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Parth10P @PavelVanecek