scripts/treeshaking.ts (1)

224-246: Defensively copy component arrays before returning report.

Line 224 currently reuses caller-provided array, so report.components can be mutated from outside via aliasing. Use a copy to keep report data stable.

Suggested patch

-export async function getBundleSizeReport(components: string | string[]): Promise<BundleSizeReport> {
-  const normalizedComponents = Array.isArray(components) ? components : [components];
+export async function getBundleSizeReport(components: string | string[]): Promise<BundleSizeReport> {
+  const normalizedComponents = Array.isArray(components) ? [...components] : [components];

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@scripts/treeshaking.ts` around lines 224 - 246, The returned report currently
reuses the caller-provided array via normalizedComponents, allowing external
mutation of report.components; change the return to store a defensive shallow
copy (e.g., use Array.from(...) or [...normalizedComponents]) for the components
property so the report's components cannot be mutated via aliasing (update the
return object that currently sets components: normalizedComponents).

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

scripts/treeshaking.ts (1)

361-370: Consider adding validation for empty component arguments.

If the script is called without any component arguments, getBundleSizeReport([]) will execute with an empty array. While this may technically work, adding a validation check would provide a better developer experience.

💡 Suggested validation

 if (require.main === module) {
   const components = process.argv.slice(2);
+  if (components.length === 0) {
+    console.error('Usage: npx tsx scripts/treeshaking.ts <ComponentName> [ComponentName...]');
+    process.exit(1);
+  }
   getBundleSizeReport(components)

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@scripts/treeshaking.ts` around lines 361 - 370, The script's entry block (the
require.main === module section) calls getBundleSizeReport with components
derived from process.argv without validating them; add a guard that checks
components.length and if zero prints a helpful usage message (including expected
component names or an example), then exits with a non-zero code (or returns) to
avoid calling getBundleSizeReport([]). Keep this validation adjacent to the
components declaration and before invoking getBundleSizeReport so the flow uses
the new check to short-circuit invalid invocation.

scripts/treeshaking.test.ts (1)

116-127: Consider adding edge case test for negative reduction.

The tests cover the happy path well. However, getReductionPercent could return negative values when reducedSizeInBytes > baselineSizeInBytes. Consider adding a test to document this behavior if it's expected, or the implementation should handle it.

💡 Suggested additional test case

   it('calculates reduction percentage', () => {
     expect(getReductionPercent(1000, 650)).toBe(35);
     expect(getReductionPercent(0, 100)).toBe(0);
+    // Document behavior when reduced > baseline (negative reduction)
+    expect(getReductionPercent(100, 150)).toBe(-50);
   });

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@scripts/treeshaking.test.ts` around lines 116 - 127, Add an edge-case test
for getReductionPercent in scripts/treeshaking.test.ts that verifies behavior
when reducedSizeInBytes > baselineSizeInBytes (e.g., baseline 100, reduced 150)
so the test either asserts the function returns a negative percent (documenting
current behavior) or, if you prefer non-negative output, update the
getReductionPercent implementation to clamp negative results to 0 and then
assert 0 in the new test; reference getReductionPercent in your changes and keep
the test grouped with the existing "calculates reduction percentage" cases.

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

scripts/treeshaking.test.ts (1)

93-113: Consider adding assertion for minified.bytes <= treeShaken.bytes.

The test validates that minified.bytes <= es6Folder.bytes but could also verify the tighter invariant that minified size is at most the tree-shaken size, similar to how minifiedGzip.bytes <= minified.bytes is checked.

♻️ Suggested additional assertion

     expect(minified.bytes).toBeLessThanOrEqual(es6Folder.bytes);
+    expect(minified.bytes).toBeLessThanOrEqual(treeShaken.bytes);
     expect(minifiedGzip.bytes).toBeLessThanOrEqual(minified.bytes);

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@scripts/treeshaking.test.ts` around lines 93 - 113, Add an assertion to
enforce the tighter invariant that the minified stage is no larger than the
tree-shaken stage in the test "returns bundle size report with es6 baseline,
tree-shaken, minified and gzip stages": after destructuring the stages into
es6Folder, treeShaken, minified, minifiedGzip (and alongside the other size
comparisons), add expect(minified.bytes).toBeLessThanOrEqual(treeShaken.bytes);
so the test verifies minified <= tree-shaken in addition to the existing
comparisons.

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro