Skip to content

Add VR test for Legend alignment#6975

Merged
PavelVanecek merged 1 commit into
mainfrom
legend-align-test
Feb 7, 2026
Merged

Add VR test for Legend alignment#6975
PavelVanecek merged 1 commit into
mainfrom
legend-align-test

Conversation

@PavelVanecek

@PavelVanecek PavelVanecek commented Feb 7, 2026 •
edited by coderabbitai Bot
Loading

Copy link
Copy Markdown
Collaborator

I am making some changes the the Legend positioning but first I want to have VR test in main.

Summary by CodeRabbit

Release Notes

  • Tests
    • Added visual regression tests for legend positioning, covering various alignment and offset configurations to ensure consistent rendering across different layout scenarios.

@coderabbitai

coderabbitai Bot commented Feb 7, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Walkthrough

This PR introduces visual regression testing infrastructure for legend positioning in charts. It adds a test component rendering multiple LineChart instances with various Legend alignment combinations and a Playwright test spec that captures screenshots for comparison.

Changes

Cohort / File(s) Summary
Legend Position VR Testing
test-vr/tests/LegendPosition.spec-vr.tsx, test-vr/tests/LegendPositionComponents.tsx		 Introduces visual regression test suite for Legend positioning. Adds LegendAlignVRTest component that renders 9 LineChart instances with all horizontal and vertical Legend alignment combinations, paired with a Playwright CT test spec that validates screenshot consistency.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~5 minutes

Suggested reviewers

  • ckifer
🚥 Pre-merge checks | ✅ 2 | ❌ 1
❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Description check ⚠️ Warning The description is incomplete. It lacks required sections including Related Issue, Motivation and Context, How Has This Been Tested, and Types of changes checkboxes. Complete the PR description by filling in all required template sections: link related issue, explain motivation, document testing approach, and mark applicable change types.
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title 'Add VR test for Legend alignment' directly and clearly summarizes the main change - adding a new visual regression test for Legend component alignment.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch legend-align-test

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@codecov

codecov Bot commented Feb 7, 2026 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.38%. Comparing base (9bbc44b) to head (551540f).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #6975   +/-   ##
=======================================
  Coverage   90.38%   90.38%           
=======================================
  Files         515      515           
  Lines       38522    38522           
  Branches     5342     5342           
=======================================
  Hits        34818    34818           
  Misses       3695     3695           
  Partials        9        9

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions

github-actions Bot commented Feb 7, 2026

Copy link
Copy Markdown
Contributor

Staging Deployment Details

These deployments will remain available for 30 days.

To update snapshots: Comment /update-snapshots on this PR to automatically update the baseline screenshots.

@PavelVanecek
PavelVanecek merged commit f45f6d8 into main Feb 7, 2026
46 of 47 checks passed
@PavelVanecek
PavelVanecek deleted the legend-align-test branch February 7, 2026 12:00
@codecov

codecov Bot commented Feb 7, 2026

Copy link
Copy Markdown

Bundle Report

Bundle size has no change ✅

@coderabbitai coderabbitai Bot mentioned this pull request May 13, 2026
Merged
This was referenced Jul 14, 2026
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@PavelVanecek