Skip to content

Remove duplicate stories#6901

Merged
PavelVanecek merged 1 commit into
mainfrom
stories
Jan 19, 2026
Merged

Remove duplicate stories#6901
PavelVanecek merged 1 commit into
mainfrom
stories

Conversation

@PavelVanecek

@PavelVanecek PavelVanecek commented Jan 18, 2026 •
edited by coderabbitai Bot
Loading

Copy link
Copy Markdown
Collaborator

Description

The website already has identical charts so let's not have this twice.

Also some of these are using Cell which we're going to remove so let's not promote that.

Related Issue

#6734

#6668

Summary by CodeRabbit

  • New Features

    • Interactive legend for bar charts (hover highlight + click-to-lock).
    • Tooltip support for custom-shaped bar chart.
    • Improved area chart layout with enhanced animations.

  • Documentation

    • Added description explaining stacked vs non-stacked bars and legend interaction.

  • Chores

    • Removed several example variants for AreaChart and BarChart to streamline showcased examples.

✏️ Tip: You can customize this high-level summary in your review settings.

@coderabbitai

coderabbitai Bot commented Jan 18, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Walkthrough

This PR removes multiple Storybook stories from AreaChart and BarChart story files and updates three example components: adds an interactive legend to MixBarChart, a grid layout and animations to SynchronizedAreaChart, and a Tooltip to CustomShapeBarChart.

Changes

Cohort / File(s) Summary
Storybook story removals
storybook/stories/Examples/AreaChart.stories.tsx, storybook/stories/Examples/BarChart/BarChart.stories.tsx		 Deleted multiple exported stories: 6 AreaChart stories (e.g., Simple, PercentAreaChart, CardinalAreaChart, AreaChartConnectNulls, SynchronisedAreaChart, AreaChartFillByValue) and 9 BarChart stories (e.g., Simple, Mix, WithBrush, WithCustomizedEvent, StackedBySign, Biaxial, HasBackground, WithMultiXAxis, PositiveAndNegative), plus related example data and the curveCardinal import.
Interactive legend (BarChart)
www/src/docs/exampleComponents/BarChart/MixBarChart.tsx, www/src/docs/exampleComponents/BarChart/index.tsx		 Added local state (focusedDataKey, locked) and legend handlers (onLegendMouseEnter, onLegendMouseOut, onLegendClick) to highlight/dim bars; imported useState and LegendPayload; added description string to MixBarChart example metadata.
Grid layout & animations (AreaChart)
www/src/docs/exampleComponents/AreaChart/SynchronizedAreaChart.tsx		 Replaced fragment with a CSS grid container (2 columns, 2 rows), removed previous inline sizing on first two AreaCharts, added animations to second AreaChart, and introduced a third AreaChart spanning both columns with custom styling and animation.
Tooltip addition (BarChart)
www/src/docs/exampleComponents/BarChart/CustomShapeBarChart.tsx		 Added Tooltip import from recharts and inserted a <Tooltip cursor={{ fillOpacity: 0.5 }} /> into the BarChart.

Sequence Diagram(s)

(omitted — changes don't introduce multi-component sequential flows requiring visualization)

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related PRs

Suggested reviewers

  • ckifer
🚥 Pre-merge checks | ✅ 1 | ❌ 2
❌ Failed checks (1 warning, 1 inconclusive)
Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
Description check ❓ Inconclusive The description provides context and motivation but is missing required sections like 'How Has This Been Tested?' and 'Types of changes' checklist that are specified in the repository template. Complete the pull request description by adding the 'How Has This Been Tested?' section, marking appropriate boxes in 'Types of changes', and filling out the 'Checklist' section.
✅ Passed checks (1 passed)
Check name Status Explanation
Title check ✅ Passed The title 'Remove duplicate stories' accurately captures the main change across the pull request—six stories from AreaChart.stories.tsx and nine from BarChart.stories.tsx are being deleted due to duplication on the website.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@codecov

codecov Bot commented Jan 18, 2026 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 72.60274% with 20 lines in your changes missing coverage. Please review.
✅ Project coverage is 94.35%. Comparing base (23a42f4) to head (0768e1e).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...rc/docs/exampleComponents/BarChart/MixBarChart.tsx 35.48% 20 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #6901      +/-   ##
==========================================
- Coverage   94.38%   94.35%   -0.03%     
==========================================
  Files         566      566              
  Lines       55342    55404      +62     
  Branches     5179     5182       +3     
==========================================
+ Hits        52233    52275      +42     
- Misses       3100     3120      +20     
  Partials        9        9

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions

github-actions Bot commented Jan 18, 2026

Copy link
Copy Markdown
Contributor

Staging Deployment Details

These deployments will remain available for 30 days.

To update snapshots: Comment /update-snapshots on this PR to automatically update the baseline screenshots.

@ckifer

ckifer commented Jan 18, 2026

Copy link
Copy Markdown
Member

Conflicts

@github-actions

github-actions Bot commented Jan 19, 2026

Copy link
Copy Markdown
Contributor

Staging Deployment Details

These deployments will remain available for 30 days.

To update snapshots: Comment /update-snapshots on this PR to automatically update the baseline screenshots.

@codecov

codecov Bot commented Jan 19, 2026

Copy link
Copy Markdown

Bundle Report

Bundle size has no change ✅

@PavelVanecek
PavelVanecek merged commit 0374d8e into main Jan 19, 2026
44 of 47 checks passed
@PavelVanecek
PavelVanecek deleted the stories branch January 19, 2026 10:43
@coderabbitai coderabbitai Bot mentioned this pull request Mar 3, 2026
Merged
5 tasks
@coderabbitai coderabbitai Bot mentioned this pull request Mar 12, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ckifer ckifer ckifer approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@PavelVanecek @ckifer