Skip to content

chore:upgrade recharts#6672

Merged
ckifer merged 1 commit into
mainfrom
upgrade-recharts35
Nov 23, 2025
Merged

chore:upgrade recharts#6672
ckifer merged 1 commit into
mainfrom
upgrade-recharts35

Conversation

@ckifer

@ckifer ckifer commented Nov 23, 2025

Copy link
Copy Markdown
Member

upgrade to 3.5

Summary by CodeRabbit

  • Chores
    • Updated library dependency to a newer version.

✏️ Tip: You can customize this high-level summary in your review settings.

@coderabbitai

coderabbitai Bot commented Nov 23, 2025

Copy link
Copy Markdown
Contributor

Walkthrough

The pull request updates the recharts dependency version from ^3.4.1 to ^3.5.0 in the www/package.json file. This is a patch-level version increment for the charting library.

Changes

Cohort / File(s) Summary
Dependency Version Update
www/package.json
Updated recharts from ^3.4.1 to ^3.5.0

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

  • Single-line dependency version bump with no logic changes or functional impact

Possibly related PRs

Suggested reviewers

  • PavelVanecek

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Description check ⚠️ Warning The description 'upgrade to 3.5' is extremely minimal and fails to follow the repository's template, missing required sections like Related Issue, Motivation and Context, testing details, and change type classifications. Provide a detailed description following the template: include the related issue link, explain why the upgrade is needed, describe testing performed, and check the appropriate change type boxes.
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title 'chore:upgrade recharts' clearly and concisely describes the main change - upgrading the recharts dependency, matching the actual changeset.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch upgrade-recharts35

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 2bf10c9 and f007648.

⛔ Files ignored due to path filters (1)
  • package-lock.json is excluded by !**/package-lock.json
📒 Files selected for processing (1)
  • www/package.json (1 hunks)
🧰 Additional context used
🧠 Learnings (2)
📓 Common learnings
Learnt from: PavelVanecek
Repo: recharts/recharts PR: 6659
File: www/src/components/GuideView/Performance/index.tsx:232-250
Timestamp: 2025-11-19T14:08:01.728Z
Learning: In Recharts version 3.4.2, object-as-prop optimizations were introduced to reduce unnecessary re-renders when new object references are passed as props. This affects the recommendation for the `react-perf/jsx-no-new-object-as-prop` ESLint rule.
📚 Learning: 2025-11-19T14:08:01.728Z
Learnt from: PavelVanecek
Repo: recharts/recharts PR: 6659
File: www/src/components/GuideView/Performance/index.tsx:232-250
Timestamp: 2025-11-19T14:08:01.728Z
Learning: In Recharts version 3.4.2, object-as-prop optimizations were introduced to reduce unnecessary re-renders when new object references are passed as props. This affects the recommendation for the `react-perf/jsx-no-new-object-as-prop` ESLint rule.

Applied to files:

  • www/package.json
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
  • GitHub Check: Build, Test, Pack
  • GitHub Check: Analyze (javascript-typescript)

Comment thread www/package.json
"react-router-dom": "^7.9.5",
"react-runner": "^1.0.5",
"recharts": "^3.4.1",
"recharts": "^3.5.0",

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🔴 Critical

❓ Verification inconclusive

Non-existent version specified—npm install will fail.

The latest published version of recharts is 3.4.1, released on November 10, 2025. Version 3.5.0 does not exist on npm or in the GitHub releases, so npm install will fail with a "version not found" error when attempting to resolve ^3.5.0.

Verify the intended target version. If this is meant to target an upcoming release that hasn't been published yet, this PR should be deferred until the release is available. Alternatively, if a different version number was intended (e.g., 3.4.x), update the version specifier accordingly.


Non-existent version specified—npm install will fail.

The latest published version of recharts is 3.4.1, released on November 10, 2025. Version 3.5.0 does not exist on npm, so npm install will fail with a "version not found" error when attempting to resolve ^3.5.0.

Verify the intended target version. If this is meant for an unreleased version, defer this PR until the release is available. If a different version was intended, update the version specifier in www/package.json line 45 accordingly.

🤖 Prompt for AI Agents
In www/package.json around line 45, the dependency specifies "recharts":
"^3.5.0" which does not exist on npm and will cause npm install to fail; either
update the version specifier to a published release (for example change to
"^3.4.1" or "3.4.1" if you want an exact pin), or if 3.5.0 was intended but
unreleased, revert this change and defer the PR until the package is published,
or remove the dependency if it is unused.

@codecov

codecov Bot commented Nov 23, 2025

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94.03%. Comparing base (2bf10c9) to head (f007648).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6672   +/-   ##
=======================================
  Coverage   94.03%   94.03%           
=======================================
  Files         497      497           
  Lines       42609    42609           
  Branches     4871     4871           
=======================================
  Hits        40066    40066           
  Misses       2538     2538           
  Partials        5        5           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ckifer
ckifer merged commit 986928b into main Nov 23, 2025
26 of 28 checks passed
@ckifer
ckifer deleted the upgrade-recharts35 branch November 23, 2025 06:33
@codecov

codecov Bot commented Nov 23, 2025

Copy link
Copy Markdown

Bundle Report

Bundle size has no change ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant