Skip to content

3.5#6671

Merged
ckifer merged 2 commits into
mainfrom
3.5
Nov 23, 2025
Merged

3.5#6671
ckifer merged 2 commits into
mainfrom
3.5

Conversation

@ckifer

@ckifer ckifer commented Nov 23, 2025 •
edited by coderabbitai Bot
Loading

Copy link
Copy Markdown
Member

bump to 3.5

Summary by CodeRabbit

  • Chores
    • Updated package version to 3.5.0
  • Documentation
    • Updated version references in component documentation

✏️ Tip: You can customize this high-level summary in your review settings.

Coltin Kifer added 2 commits November 22, 2025 21:25
@ckifer
ckifer requested a review from PavelVanecek November 23, 2025 05:26
@coderabbitai

coderabbitai Bot commented Nov 23, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

Walkthrough

Version number is incremented from 3.4.1 to 3.5.0 in package.json. Documentation comment in the Performance guide component is updated to reference the new version number.

Changes

Cohort / File(s) Summary
Package version metadata
package.json		 Version bumped from 3.4.1 to 3.5.0
Documentation updates
www/src/components/GuideView/Performance/index.tsx		 Comment updated to reference version 3.5.0 instead of 3.4.2

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

  • 3.4.0 #6596: Performs a similar version bump to package.json (from 3.4.0 to related version), indicating part of a versioning release sequence

Pre-merge checks and finishing touches

❌ Failed checks (2 warnings, 1 inconclusive)
Check name Status Explanation Resolution
Description check ⚠️ Warning The description 'bump to 3.5' is minimal and lacks required sections like Related Issue, Motivation and Context, and testing details from the template. Expand the description to include all template sections: Related Issue, Motivation and Context, How Has This Been Tested, and appropriate checkboxes for types of changes.
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. You can run @coderabbitai generate docstrings to improve docstring coverage.
Title check ❓ Inconclusive The title '3.5' is extremely vague and generic, providing no meaningful information about the changeset beyond a version number. Replace with a descriptive title that clearly summarizes the changes, such as 'Bump version to 3.5.0' or 'Release version 3.5.0'.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch 3.5
📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 41c2b94 and 075160f.

⛔ Files ignored due to path filters (1)
  • package-lock.json is excluded by !**/package-lock.json
📒 Files selected for processing (2)
  • package.json (1 hunks)
  • www/src/components/GuideView/Performance/index.tsx (1 hunks)
🧰 Additional context used
🧠 Learnings (2)
📚 Learning: 2025-11-19T14:08:01.728Z 
Learnt from: PavelVanecek
Repo: recharts/recharts PR: 6659
File: www/src/components/GuideView/Performance/index.tsx:232-250
Timestamp: 2025-11-19T14:08:01.728Z
Learning: In Recharts version 3.4.2, object-as-prop optimizations were introduced to reduce unnecessary re-renders when new object references are passed as props. This affects the recommendation for the `react-perf/jsx-no-new-object-as-prop` ESLint rule.

Applied to files:

  • package.json
  • www/src/components/GuideView/Performance/index.tsx
📚 Learning: 2025-11-16T09:14:24.918Z 
Learnt from: PavelVanecek
Repo: recharts/recharts PR: 6640
File: src/cartesian/Bar.tsx:156-159
Timestamp: 2025-11-16T09:14:24.918Z
Learning: In recharts, SSR (Server-Side Rendering) is not yet supported—charts don't render at all in SSR environments. The `isAnimationActive: 'auto'` mode is preparatory work for future SSR support, so testing of this mode should be deferred until SSR support is actually implemented.

Applied to files:

  • www/src/components/GuideView/Performance/index.tsx
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
  • GitHub Check: Build, Test, Pack
  • GitHub Check: Analyze (javascript-typescript)
🔇 Additional comments (2)
www/src/components/GuideView/Performance/index.tsx (1)

239-239: LGTM! Documentation updated to reflect the correct version.

The version reference update from 3.4.2 to 3.5.0 correctly aligns with the version bump in package.json. This maintains accurate documentation about when the object-as-prop optimization was introduced.

Based on learnings, the object-as-prop optimization feature referenced here is a legitimate enhancement introduced in this release cycle.

package.json (1)

3-3: Version bump is correct and complete.

The verification confirms:

  • Root package.json correctly bumped to 3.5.0
  • CHANGELOG.md uses GitHub Releases for version documentation (as per its header), not per-version entries in the file
  • No hardcoded version strings requiring updates (package-lock.json is auto-generated; www/package.json correctly uses semver ^3.4.1 for the recharts dependency)
  • www/package.json (documentation website) intentionally maintains independent versioning (3.0.0)

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@codecov

codecov Bot commented Nov 23, 2025 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94.03%. Comparing base (41c2b94) to head (075160f).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #6671   +/-   ##
=======================================
  Coverage   94.03%   94.03%           
=======================================
  Files         497      497           
  Lines       42609    42609           
  Branches     4871     4871           
=======================================
  Hits        40066    40066           
  Misses       2538     2538           
  Partials        5        5

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ckifer
ckifer merged commit 2bf10c9 into main Nov 23, 2025
26 of 28 checks passed
@ckifer
ckifer deleted the 3.5 branch November 23, 2025 05:45
@coderabbitai coderabbitai Bot mentioned this pull request Nov 23, 2025
Merged
@codecov

codecov Bot commented Nov 23, 2025

Copy link
Copy Markdown

Bundle Report

Bundle size has no change ✅

@coderabbitai coderabbitai Bot mentioned this pull request Nov 25, 2025
Merged
@coderabbitai coderabbitai Bot mentioned this pull request Jan 21, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@PavelVanecek PavelVanecek PavelVanecek approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ckifer @PavelVanecek