Skip to content

fix: label not being rendered due to filterProps#6018

Merged
ckifer merged 1 commit into
recharts:mainfrom
saurabhraj123:bugFix/customized-label-not-being-render
Jun 26, 2025
Merged

fix: label not being rendered due to filterProps#6018
ckifer merged 1 commit into
recharts:mainfrom
saurabhraj123:bugFix/customized-label-not-being-render

Conversation

@saurabhraj123

@saurabhraj123 saurabhraj123 commented Jun 26, 2025

Copy link
Copy Markdown
Contributor

Description

Fix: label not being rendered due to filterProps

Related Issue

#6008

Screenshots (if appropriate):

Fix:

Screenshot 2025-06-26 at 10 11 53 AM

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • I have added a storybook story or extended an existing story to show my changes

@codecov

codecov Bot commented Jun 26, 2025

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.27%. Comparing base (85e2f43) to head (c072317).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6018   +/-   ##
=======================================
  Coverage   96.27%   96.27%           
=======================================
  Files         194      194           
  Lines       19660    19661    +1     
  Branches     4029     4030    +1     
=======================================
+ Hits        18927    18928    +1     
  Misses        727      727           
  Partials        6        6           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@PavelVanecek PavelVanecek left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you find some time to add a unit test for this scenario too please?

@saurabhraj123

Copy link
Copy Markdown
Contributor Author

Can you find some time to add a unit test for this scenario too please?

Will add @PavelVanecek

@ckifer

ckifer commented Jun 26, 2025

Copy link
Copy Markdown
Member

merging the fix to release a patch version, please follow up if you can

@ckifer
ckifer merged commit 8540061 into recharts:main Jun 26, 2025
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants