Skip to content

fix: cross storybook build#3543

Merged
ckifer merged 2 commits into
recharts:masterfrom
ckifer:fix/cross-story
Apr 18, 2023
Merged

fix: cross storybook build#3543
ckifer merged 2 commits into
recharts:masterfrom
ckifer:fix/cross-story

Conversation

@ckifer

@ckifer ckifer commented Apr 18, 2023

Copy link
Copy Markdown
Member

Description

fixes broken build due to cross story

confirmed storybook build succeeds

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Comment thread storybook/stories/API/shapes/Cross.stories.tsx Outdated
Comment thread storybook/stories/API/shapes/Cross.mdx Outdated
Comment thread storybook/stories/API/shapes/Cross.mdx Outdated
@ckifer
ckifer merged commit a32f1ee into recharts:master Apr 18, 2023
@ckifer
ckifer deleted the fix/cross-story branch April 18, 2023 18:45
@nikolasrieble

Copy link
Copy Markdown
Contributor

🤦 Thanks for the quick fix.

@ckifer

ckifer commented Apr 18, 2023

Copy link
Copy Markdown
Member Author

No worries at all, we don't build the storybook pre-push

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants