Skip to content

fix: CI error#3487

Merged
ckifer merged 1 commit into
recharts:masterfrom
Yilun-Sun:syl/fix-ci-error
Mar 28, 2023
Merged

fix: CI error#3487
ckifer merged 1 commit into
recharts:masterfrom
Yilun-Sun:syl/fix-ci-error

Conversation

@Yilun-Sun

@Yilun-Sun Yilun-Sun commented Mar 27, 2023

Copy link
Copy Markdown
Member

image

CI error blocks all new PRs.

image

Description

Related Issue

PR has ci error:
#3484

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@Yilun-Sun
Yilun-Sun marked this pull request as ready for review March 27, 2023 06:17
@Yilun-Sun Yilun-Sun added the P1 High priority issues label Mar 28, 2023
@Yilun-Sun Yilun-Sun changed the title fix: ci error fix: CI error Mar 28, 2023
Comment thread src/util/DataUtils.ts
@ckifer

ckifer commented Mar 28, 2023

Copy link
Copy Markdown
Member

thank you! This isn't really ideal because width is still able to be a number or string and we're casting it to a Number. But better than before.

@ckifer
ckifer merged commit d598745 into recharts:master Mar 28, 2023
@Yilun-Sun
Yilun-Sun deleted the syl/fix-ci-error branch March 29, 2023 02:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

P1 High priority issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants