Skip to content

Storybook: add ErrorBar stories#3484

Merged
ckifer merged 1 commit into
recharts:masterfrom
Yilun-Sun:syl/feat-add-error-bar-storie
Mar 29, 2023
Merged

Storybook: add ErrorBar stories#3484
ckifer merged 1 commit into
recharts:masterfrom
Yilun-Sun:syl/feat-add-error-bar-storie

Conversation

@Yilun-Sun

Copy link
Copy Markdown
Member

Description

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@Yilun-Sun
Yilun-Sun marked this pull request as ready for review March 24, 2023 09:47
@Yilun-Sun
Yilun-Sun force-pushed the syl/feat-add-error-bar-storie branch from 26034bf to 663cee4 Compare March 24, 2023 10:42
@ckifer

ckifer commented Mar 26, 2023

Copy link
Copy Markdown
Member

Looks like some failing CI, but not from this PR... Weird. We should fix that before reviewing/merging this.

@Yilun-Sun Yilun-Sun mentioned this pull request Mar 27, 2023
8 tasks
ckifer pushed a commit that referenced this pull request Mar 28, 2023
<!--- Provide a general summary of your changes in the Title above -->


![image](https://user-images.githubusercontent.com/43896664/228121708-a75b31f8-6012-492e-9826-4df96b39007e.png)

CI error blocks all new PRs.


![image](https://user-images.githubusercontent.com/43896664/228121630-07b98117-8304-4bfe-9924-a9f0e309ef63.png)


## Description

<!--- Describe your changes in detail -->

## Related Issue

PR has ci error:
#3484 

<!--- This project only accepts pull requests related to open issues -->
<!--- If suggesting a new feature or change, please discuss it in an
issue first -->
<!--- If fixing a bug, there should be an issue describing it with steps
to reproduce -->
<!--- Please link to the issue here: -->

## Motivation and Context

<!--- Why is this change required? What problem does it solve? -->

## How Has This Been Tested?

<!--- Please describe in detail how you tested your changes. -->
<!--- Include details of your testing environment, and the tests you ran
to -->
<!--- see how your change affects other areas of the code, etc. -->

## Screenshots (if appropriate):

## Types of changes

<!--- What types of changes does your code introduce? Put an `x` in all
the boxes that apply: -->

- [ ] Bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing
functionality to change)

## Checklist:

<!--- Go over all the following points, and put an `x` in all the boxes
that apply. -->
<!--- If you're unsure about any of these, don't hesitate to ask. We're
here to help! -->

- [ ] My code follows the code style of this project.
- [ ] My change requires a change to the documentation.
- [ ] I have updated the documentation accordingly.
- [ ] I have added tests to cover my changes.
- [ ] All new and existing tests passed.

@ckifer ckifer left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you

@ckifer
ckifer merged commit d7a6207 into recharts:master Mar 29, 2023
@Yilun-Sun
Yilun-Sun deleted the syl/feat-add-error-bar-storie branch March 30, 2023 02:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants