ChartUtils: GetTicks only returns valid ticks that are part of the current domain.#3454
Merged
nikolasrieble merged 10 commits intoMar 13, 2023
Merged
Conversation
nikolasrieble
commented
Mar 13, 2023
nikolasrieble
commented
Mar 13, 2023
nikolasrieble
commented
Mar 13, 2023
nikolasrieble
commented
Mar 13, 2023
nikolasrieble
commented
Mar 13, 2023
| }; | ||
| }); | ||
|
|
||
| return result.filter((row: TickItem) => !_.isNaN(row.coordinate)); |
Contributor
Author
There was a problem hiding this comment.
Finally the fix.
Member
There was a problem hiding this comment.
So there is no way to fix this upstream just because of the way that PointScale works?
Contributor
Author
There was a problem hiding this comment.
Upstream nothing is broken. This is about the domain being filtered by the brush - as it should - and the PointScale simply has no coordinates for items outside of the domain.
That is how the point scale works.
Contributor
Author
There was a problem hiding this comment.
To my best understanding, all works as it should - but this function.
Member
There was a problem hiding this comment.
Got it. Logically in my head I think I'd want the data itself to be filtered and then everything trickle down into domain and ticks from there. Makes sense, but these are the kind of fragile pieces we have to keep an eye on and harden/test
Member
There was a problem hiding this comment.
Also do we want to use _.isNaN(row.coordinate) as opposed to Number.isNaN(row.coordinate)? The more we use lodash the more we have dependency on it (I know its used a ton but just future thinking)
ckifer
approved these changes
Mar 13, 2023
| }; | ||
| }); | ||
|
|
||
| return result.filter((row: TickItem) => !_.isNaN(row.coordinate)); |
Member
There was a problem hiding this comment.
So there is no way to fix this upstream just because of the way that PointScale works?
1 task
Lukas742
referenced
this pull request
in UI5/webcomponents-react
Mar 17, 2023
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [recharts](https://togithub.com/recharts/recharts) | [`2.4.3` -> `2.5.0`](https://renovatebot.com/diffs/npm/recharts/2.4.3/2.5.0) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>recharts/recharts</summary> ### [`v2.5.0`](https://togithub.com/recharts/recharts/releases/tag/v2.5.0) [Compare Source](https://togithub.com/recharts/recharts/compare/v2.4.3...v2.5.0) #### What's Changed ##### Feat - `ResponsiveContainer`: `onResize` callback function by [@​ckifer](https://togithub.com/ckifer) in [https://github.com/recharts/recharts/pull/3361](https://togithub.com/recharts/recharts/pull/3361) - `XAxis`, `YAxis`: `includeHidden` prop - include all datapoints in domain calculation even when hidden by [@​neefrehman](https://togithub.com/neefrehman) in [https://github.com/recharts/recharts/pull/3103](https://togithub.com/recharts/recharts/pull/3103) - `XAxis`, `YAxis`: new interval option `equidistantPreserveStart` by [@​nikolasrieble](https://togithub.com/nikolasrieble) in [https://github.com/recharts/recharts/pull/3392](https://togithub.com/recharts/recharts/pull/3392) ##### Fix - `ResponsiveContainer`: default min-width to 0 to override default auto behavior that breaks flexbox layouts by [@​ckifer](https://togithub.com/ckifer) in [https://github.com/recharts/recharts/pull/3391](https://togithub.com/recharts/recharts/pull/3391) - `Area`: Add missing 'data' type to Area component by [@​ondrejvelisek](https://togithub.com/ondrejvelisek) in [https://github.com/recharts/recharts/pull/3443](https://togithub.com/recharts/recharts/pull/3443) - `Brush`/`XAxis`: fix NaN regression when `interval={0}` by [@​nikolasrieble](https://togithub.com/nikolasrieble) in [https://github.com/recharts/recharts/pull/3454](https://togithub.com/recharts/recharts/pull/3454) - `ReferenceArea`/`ReferenceLine`: revert regression where `ifOverflow` prop is not obeyed due to missing defaultProps by [@​ckifer](https://togithub.com/ckifer) in [https://github.com/recharts/recharts/pull/3455](https://togithub.com/recharts/recharts/pull/3455) ##### Docs - lots of storybook changes - [go check it out](https://master--63da8268a0da9970db6992aa.chromatic.com/)! ##### Dependencies - chore: explicitly upgrade minor version of react-smooth by [@​ckifer](https://togithub.com/ckifer) in [https://github.com/recharts/recharts/pull/3397](https://togithub.com/recharts/recharts/pull/3397) - chore: upgrade react-resize-detector to 8.x by [@​ckifer](https://togithub.com/ckifer) in [https://github.com/recharts/recharts/pull/3418](https://togithub.com/recharts/recharts/pull/3418) ##### Refactor - Refactoring: Adapt getTicks to increase reusability of code by [@​nikolasrieble](https://togithub.com/nikolasrieble) in [https://github.com/recharts/recharts/pull/3393](https://togithub.com/recharts/recharts/pull/3393) - Refactoring: Extract TicksUtils from CartesianAxis and add unit tests by [@​nikolasrieble](https://togithub.com/nikolasrieble) in [https://github.com/recharts/recharts/pull/3386](https://togithub.com/recharts/recharts/pull/3386) #### New Contributors - [@​ondrejvelisek](https://togithub.com/ondrejvelisek) made their first contribution in [https://github.com/recharts/recharts/pull/3443](https://togithub.com/recharts/recharts/pull/3443) **Full Changelog**: recharts/recharts@v2.4.3...v2.5.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/SAP/ui5-webcomponents-react). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNS44LjMiLCJ1cGRhdGVkSW5WZXIiOiIzNS45LjAifQ==--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
scudette
added a commit
to Velocidex/velociraptor
that referenced
this pull request
Apr 8, 2023
<p>This PR was automatically created by Snyk using the credentials of a
real user.</p><br /><h3>Snyk has created this PR to upgrade recharts
from 2.4.3 to 2.5.0.</h3>
:information_source: Keep your dependencies up-to-date. This makes it
easier to fix existing vulnerabilities and to more quickly identify and
fix newly disclosed vulnerabilities when they affect your project.
<hr/>
- The recommended version is **1 version** ahead of your current
version.
- The recommended version was released **23 days ago**, on 2023-03-15.
<details>
<summary><b>Release notes</b></summary>
<br/>
<details>
<summary>Package name: <b>recharts</b></summary>
<ul>
<li>
<b>2.5.0</b> - <a
href="https://snyk.io/redirect/github/recharts/recharts/releases/tag/v2.5.0">2023-03-15</a></br><h2>What's
Changed</h2>
<h3>Feat</h3>
<ul>
<li><code>ResponsiveContainer</code>: <code>onResize</code> callback
function by <a class="user-mention notranslate"
data-hovercard-type="user" data-hovercard-url="/users/ckifer/hovercard"
data-octo-click="hovercard-link-click"
data-octo-dimensions="link_type:self"
href="https://snyk.io/redirect/github/ckifer">@ ckifer</a> in <a
class="issue-link js-issue-link" data-error-text="Failed to load title"
data-id="1582916569" data-permission-text="Title is private"
data-url="recharts/recharts#3361"
data-hovercard-type="pull_request"
data-hovercard-url="/recharts/recharts/pull/3361/hovercard"
href="https://snyk.io/redirect/github/recharts/recharts/pull/3361">#3361</a></li>
<li><code>XAxis</code>, <code>YAxis</code>: <code>includeHidden</code>
prop - include all datapoints in domain calculation even when hidden by
<a class="user-mention notranslate" data-hovercard-type="user"
data-hovercard-url="/users/neefrehman/hovercard"
data-octo-click="hovercard-link-click"
data-octo-dimensions="link_type:self"
href="https://snyk.io/redirect/github/neefrehman">@ neefrehman</a> in <a
class="issue-link js-issue-link" data-error-text="Failed to load title"
data-id="1500101512" data-permission-text="Title is private"
data-url="recharts/recharts#3103"
data-hovercard-type="pull_request"
data-hovercard-url="/recharts/recharts/pull/3103/hovercard"
href="https://snyk.io/redirect/github/recharts/recharts/pull/3103">#3103</a></li>
<li><code>XAxis</code>, <code>YAxis</code>: new interval option
<code>equidistantPreserveStart</code> by <a class="user-mention
notranslate" data-hovercard-type="user"
data-hovercard-url="/users/nikolasrieble/hovercard"
data-octo-click="hovercard-link-click"
data-octo-dimensions="link_type:self"
href="https://snyk.io/redirect/github/nikolasrieble">@ nikolasrieble</a>
in <a class="issue-link js-issue-link" data-error-text="Failed to load
title" data-id="1594785191" data-permission-text="Title is private"
data-url="recharts/recharts#3392"
data-hovercard-type="pull_request"
data-hovercard-url="/recharts/recharts/pull/3392/hovercard"
href="https://snyk.io/redirect/github/recharts/recharts/pull/3392">#3392</a></li>
</ul>
<h3>Fix</h3>
<ul>
<li><code>ResponsiveContainer</code>: default min-width to 0 to override
default auto behavior that breaks flexbox layouts by <a
class="user-mention notranslate" data-hovercard-type="user"
data-hovercard-url="/users/ckifer/hovercard"
data-octo-click="hovercard-link-click"
data-octo-dimensions="link_type:self"
href="https://snyk.io/redirect/github/ckifer">@ ckifer</a> in <a
class="issue-link js-issue-link" data-error-text="Failed to load title"
data-id="1594523953" data-permission-text="Title is private"
data-url="recharts/recharts#3391"
data-hovercard-type="pull_request"
data-hovercard-url="/recharts/recharts/pull/3391/hovercard"
href="https://snyk.io/redirect/github/recharts/recharts/pull/3391">#3391</a></li>
<li><code>Area</code>: Add missing 'data' type to Area component by <a
class="user-mention notranslate" data-hovercard-type="user"
data-hovercard-url="/users/ondrejvelisek/hovercard"
data-octo-click="hovercard-link-click"
data-octo-dimensions="link_type:self"
href="https://snyk.io/redirect/github/ondrejvelisek">@ ondrejvelisek</a>
in <a class="issue-link js-issue-link" data-error-text="Failed to load
title" data-id="1615470205" data-permission-text="Title is private"
data-url="recharts/recharts#3443"
data-hovercard-type="pull_request"
data-hovercard-url="/recharts/recharts/pull/3443/hovercard"
href="https://snyk.io/redirect/github/recharts/recharts/pull/3443">#3443</a></li>
<li><code>Brush</code>/<code>XAxis</code>: fix NaN regression when
<code>interval={0}</code> by <a class="user-mention notranslate"
data-hovercard-type="user"
data-hovercard-url="/users/nikolasrieble/hovercard"
data-octo-click="hovercard-link-click"
data-octo-dimensions="link_type:self"
href="https://snyk.io/redirect/github/nikolasrieble">@ nikolasrieble</a>
in <a class="issue-link js-issue-link" data-error-text="Failed to load
title" data-id="1622213441" data-permission-text="Title is private"
data-url="recharts/recharts#3454"
data-hovercard-type="pull_request"
data-hovercard-url="/recharts/recharts/pull/3454/hovercard"
href="https://snyk.io/redirect/github/recharts/recharts/pull/3454">#3454</a></li>
<li><code>ReferenceArea</code>/<code>ReferenceLine</code>: revert
regression where <code>ifOverflow</code> prop is not obeyed due to
missing defaultProps by <a class="user-mention notranslate"
data-hovercard-type="user" data-hovercard-url="/users/ckifer/hovercard"
data-octo-click="hovercard-link-click"
data-octo-dimensions="link_type:self"
href="https://snyk.io/redirect/github/ckifer">@ ckifer</a> in <a
class="issue-link js-issue-link" data-error-text="Failed to load title"
data-id="1622808868" data-permission-text="Title is private"
data-url="recharts/recharts#3455"
data-hovercard-type="pull_request"
data-hovercard-url="/recharts/recharts/pull/3455/hovercard"
href="https://snyk.io/redirect/github/recharts/recharts/pull/3455">#3455</a></li>
</ul>
<h3>Docs</h3>
<ul>
<li>lots of storybook changes - <a
href="https://master--63da8268a0da9970db6992aa.chromatic.com/"
rel="nofollow">go check it out</a>!</li>
</ul>
<h3>Dependencies</h3>
<ul>
<li>chore: explicitly upgrade minor version of react-smooth by <a
class="user-mention notranslate" data-hovercard-type="user"
data-hovercard-url="/users/ckifer/hovercard"
data-octo-click="hovercard-link-click"
data-octo-dimensions="link_type:self"
href="https://snyk.io/redirect/github/ckifer">@ ckifer</a> in <a
class="issue-link js-issue-link" data-error-text="Failed to load title"
data-id="1597775617" data-permission-text="Title is private"
data-url="recharts/recharts#3397"
data-hovercard-type="pull_request"
data-hovercard-url="/recharts/recharts/pull/3397/hovercard"
href="https://snyk.io/redirect/github/recharts/recharts/pull/3397">#3397</a></li>
<li>chore: upgrade react-resize-detector to 8.x by <a
class="user-mention notranslate" data-hovercard-type="user"
data-hovercard-url="/users/ckifer/hovercard"
data-octo-click="hovercard-link-click"
data-octo-dimensions="link_type:self"
href="https://snyk.io/redirect/github/ckifer">@ ckifer</a> in <a
class="issue-link js-issue-link" data-error-text="Failed to load title"
data-id="1607429776" data-permission-text="Title is private"
data-url="recharts/recharts#3418"
data-hovercard-type="pull_request"
data-hovercard-url="/recharts/recharts/pull/3418/hovercard"
href="https://snyk.io/redirect/github/recharts/recharts/pull/3418">#3418</a></li>
</ul>
<h3>Refactor</h3>
<ul>
<li>Refactoring: Adapt getTicks to increase reusability of code by <a
class="user-mention notranslate" data-hovercard-type="user"
data-hovercard-url="/users/nikolasrieble/hovercard"
data-octo-click="hovercard-link-click"
data-octo-dimensions="link_type:self"
href="https://snyk.io/redirect/github/nikolasrieble">@ nikolasrieble</a>
in <a class="issue-link js-issue-link" data-error-text="Failed to load
title" data-id="1595050186" data-permission-text="Title is private"
data-url="recharts/recharts#3393"
data-hovercard-type="pull_request"
data-hovercard-url="/recharts/recharts/pull/3393/hovercard"
href="https://snyk.io/redirect/github/recharts/recharts/pull/3393">#3393</a></li>
<li>Refactoring: Extract TicksUtils from CartesianAxis and add unit
tests by <a class="user-mention notranslate" data-hovercard-type="user"
data-hovercard-url="/users/nikolasrieble/hovercard"
data-octo-click="hovercard-link-click"
data-octo-dimensions="link_type:self"
href="https://snyk.io/redirect/github/nikolasrieble">@ nikolasrieble</a>
in <a class="issue-link js-issue-link" data-error-text="Failed to load
title" data-id="1593521268" data-permission-text="Title is private"
data-url="recharts/recharts#3386"
data-hovercard-type="pull_request"
data-hovercard-url="/recharts/recharts/pull/3386/hovercard"
href="https://snyk.io/redirect/github/recharts/recharts/pull/3386">#3386</a></li>
</ul>
<h2>New Contributors</h2>
<ul>
<li><a class="user-mention notranslate" data-hovercard-type="user"
data-hovercard-url="/users/ondrejvelisek/hovercard"
data-octo-click="hovercard-link-click"
data-octo-dimensions="link_type:self"
href="https://snyk.io/redirect/github/ondrejvelisek">@ ondrejvelisek</a>
made their first contribution in <a class="issue-link js-issue-link"
data-error-text="Failed to load title" data-id="1615470205"
data-permission-text="Title is private"
data-url="recharts/recharts#3443"
data-hovercard-type="pull_request"
data-hovercard-url="/recharts/recharts/pull/3443/hovercard"
href="https://snyk.io/redirect/github/recharts/recharts/pull/3443">#3443</a></li>
</ul>
<p><strong>Full Changelog</strong>: <a class="commit-link"
href="https://snyk.io/redirect/github/recharts/recharts/compare/v2.4.3...v2.5.0"><tt>v2.4.3...v2.5.0</tt></a></p>
</li>
<li>
<b>2.4.3</b> - <a
href="https://snyk.io/redirect/github/recharts/recharts/releases/tag/v2.4.3">2023-02-16</a></br><h2>v2.4.3</h2>
<p>cherry-picked commit <a class="commit-link"
data-hovercard-type="commit"
data-hovercard-url="https://github.com/recharts/recharts/commit/7925fd7d6e76812fe680df9844656feca21ebde9/hovercard"
href="https://snyk.io/redirect/github/recharts/recharts/commit/7925fd7d6e76812fe680df9844656feca21ebde9"><tt>7925fd7</tt></a>
to not pollute patch release with other changes</p>
<h3>fix</h3>
<ul>
<li>ensure <code>originalDomain</code> is defaulted if no domain is
provided - broke <code>tickCount</code> calculation - <a
class="issue-link js-issue-link" data-error-text="Failed to load title"
data-id="1587500881" data-permission-text="Title is private"
data-url="recharts/recharts#3377"
data-hovercard-type="issue"
data-hovercard-url="/recharts/recharts/issues/3377/hovercard"
href="https://snyk.io/redirect/github/recharts/recharts/issues/3377">#3377</a>
<ul>
<li>assign default to <code>originalDomain</code> for re-use in
generateCategoricalChart</li>
<li>add unit tests so this doesn't happen again</li>
</ul>
</li>
</ul>
<p><strong>Full Changelog</strong>: <a class="commit-link"
href="https://snyk.io/redirect/github/recharts/recharts/compare/v2.4.2...v2.4.3"><tt>v2.4.2...v2.4.3</tt></a></p>
</li>
</ul>
from <a
href="https://snyk.io/redirect/github/recharts/recharts/releases">recharts
GitHub release notes</a>
</details>
</details>
<details>
<summary><b>Commit messages</b></summary>
</br>
<details>
<summary>Package name: <b>recharts</b></summary>
<ul>
<li><a
href="https://snyk.io/redirect/github/recharts/recharts/commit/3e31520ce0a71dc48532f996900250396a135bcd">3e31520</a>
2.5.0</li>
<li><a
href="https://snyk.io/redirect/github/recharts/recharts/commit/59b1389663698820c23d8638012af7b32ef23efc">59b1389</a>
chore(deps-dev): bump webpack from 5.75.0 to 5.76.0 (#3458)</li>
<li><a
href="https://snyk.io/redirect/github/recharts/recharts/commit/ef480490a81fa9497508feb10836c02769cec715">ef48049</a>
Storybook Examples: Add all ScatterChart examples from the website to
Storybook (#3456)</li>
<li><a
href="https://snyk.io/redirect/github/recharts/recharts/commit/230bad0c1b1c6e352451baeee3537deef474d576">230bad0</a>
Revert "Refactored: added default values in params for
ReferenceAreaand ReferenceLine since default props is deprecated
(#3455)</li>
<li><a
href="https://snyk.io/redirect/github/recharts/recharts/commit/9ce59d56f1b2bda131b32d68f40273df169e6bbe">9ce59d5</a>
fix(storybook): keep reference area within chart</li>
<li><a
href="https://snyk.io/redirect/github/recharts/recharts/commit/4ee4124f3d73f9487b4b74d6aedac0f87af8d3a2">4ee4124</a>
ChartUtils: GetTicks only returns valid ticks that are part of the
current domain. (#3454)</li>
<li><a
href="https://snyk.io/redirect/github/recharts/recharts/commit/b1e7db8f3487301ee26e1ec37125d74796b4662e">b1e7db8</a>
fix: linechart storybook, add storybook types (#3451)</li>
<li><a
href="https://snyk.io/redirect/github/recharts/recharts/commit/b4a8c1a1a9377f09f46fa07dc0b97d7f4a18af8d">b4a8c1a</a>
Add missing 'data' type to Area component (#3443)</li>
<li><a
href="https://snyk.io/redirect/github/recharts/recharts/commit/d1fab30f0fce62a7f8ca26a7e936f81c2c325b37">d1fab30</a>
chore: upgrade react-resize-detector to 8.x (#3418)</li>
<li><a
href="https://snyk.io/redirect/github/recharts/recharts/commit/33ceeaf54d8583543124bf955fd7f14290d96e74">33ceeaf</a>
Storybook: Add all examples from the website for Area and Bar Chart
(#3440)</li>
<li><a
href="https://snyk.io/redirect/github/recharts/recharts/commit/0a6aa4f79c19bf4919a89c68d190f992d48894cb">0a6aa4f</a>
Storybook - Add all LineChart examples from the website (#3439)</li>
<li><a
href="https://snyk.io/redirect/github/recharts/recharts/commit/86c16b6c24803ec5cefe7bf17466045ce60457db">86c16b6</a>
Storybook: add Bar stories (#3435)</li>
<li><a
href="https://snyk.io/redirect/github/recharts/recharts/commit/8366f721dc4454a07780b948fe751d4bce2d33bd">8366f72</a>
LineStories: Simplify and unify (#3436)</li>
<li><a
href="https://snyk.io/redirect/github/recharts/recharts/commit/ecaa1821ea5193ad8b5eadb8fc24c143cefdc638">ecaa182</a>
Storybook: Create Welcome page (#3417)</li>
<li><a
href="https://snyk.io/redirect/github/recharts/recharts/commit/ac1911c12449d52fd60f897425a611374c0ab2b1">ac1911c</a>
Update CHANGELOG.md</li>
<li><a
href="https://snyk.io/redirect/github/recharts/recharts/commit/d7bbda1570694a08178fa1104fa1523934f76e80">d7bbda1</a>
Storybook: Create a doc for Line with a Table of all args. (#3404)</li>
<li><a
href="https://snyk.io/redirect/github/recharts/recharts/commit/415a554af499fc71dc1b58322c786f526d9f4321">415a554</a>
fix: unify AreaChart stories data (#3411)</li>
<li><a
href="https://snyk.io/redirect/github/recharts/recharts/commit/1ab495aa02df764236e2623aafcd4305f1a3ce33">1ab495a</a>
docs(storybook): stockprice chart(candlestick) example (#3413)</li>
<li><a
href="https://snyk.io/redirect/github/recharts/recharts/commit/a8be8f2b72dcb04eaac19d15dde4282c5e18b980">a8be8f2</a>
refactor: pass data using args in PieChart (#3412)</li>
<li><a
href="https://snyk.io/redirect/github/recharts/recharts/commit/c72da1c5c3181bd9556a0051323546293ee6d8f7">c72da1c</a>
fix: unify line stories data (#3409)</li>
<li><a
href="https://snyk.io/redirect/github/recharts/recharts/commit/5dab4c733a4be4460fe5ba4f608991ad657b5ff0">5dab4c7</a>
fix: unify area stories data (#3408)</li>
<li><a
href="https://snyk.io/redirect/github/recharts/recharts/commit/82d3b799b9e9a22ab815f6258869123bf8ffc6ce">82d3b79</a>
Storybook: Extend guidance in README (#3402)</li>
<li><a
href="https://snyk.io/redirect/github/recharts/recharts/commit/36f2f879a7908d62b4e6552f1ee5570d145eafd8">36f2f87</a>
fix(storybook): remove composed chart wrapper container (#3405)</li>
<li><a
href="https://snyk.io/redirect/github/recharts/recharts/commit/dd5edee8ee526937efd5016a3288eea552b573a7">dd5edee</a>
Storybook: improve Area stories. (#3398)</li>
</ul>
<a
href="https://snyk.io/redirect/github/recharts/recharts/compare/0701fccae8de01c0ec1cd3f80bc5f6baef3511ba...3e31520ce0a71dc48532f996900250396a135bcd">Compare</a>
</details>
</details>
<hr/>
**Note:** *You are seeing this because you or someone else with access
to this repository has authorized Snyk to open upgrade PRs.*
For more information: <img
src="https://api.segment.io/v1/pixel/track?data=eyJ3cml0ZUtleSI6InJyWmxZcEdHY2RyTHZsb0lYd0dUcVg4WkFRTnNCOUEwIiwiYW5vbnltb3VzSWQiOiJkZWY1MzU4ZC04MWI4LTQ0MzctODhhYS1iZTUxNTUzOTZjNTYiLCJldmVudCI6IlBSIHZpZXdlZCIsInByb3BlcnRpZXMiOnsicHJJZCI6ImRlZjUzNThkLTgxYjgtNDQzNy04OGFhLWJlNTE1NTM5NmM1NiJ9fQ=="
width="0" height="0"/>
🧐 [View latest project
report](https://app.snyk.io/org/scudette/project/76f4d127-566b-42ef-86f4-bdcbc92b90b4?utm_source=github&utm_medium=referral&page=upgrade-pr)
🛠 [Adjust upgrade PR
settings](https://app.snyk.io/org/scudette/project/76f4d127-566b-42ef-86f4-bdcbc92b90b4/settings/integration?utm_source=github&utm_medium=referral&page=upgrade-pr)
🔕 [Ignore this dependency or unsubscribe from future upgrade
PRs](https://app.snyk.io/org/scudette/project/76f4d127-566b-42ef-86f4-bdcbc92b90b4/settings/integration?pkg=recharts&utm_source=github&utm_medium=referral&page=upgrade-pr#auto-dep-upgrades)
<!---
(snyk:metadata:{"prId":"def5358d-81b8-4437-88aa-be5155396c56","prPublicId":"def5358d-81b8-4437-88aa-be5155396c56","dependencies":[{"name":"recharts","from":"2.4.3","to":"2.5.0"}],"packageManager":"npm","type":"auto","projectUrl":"https://app.snyk.io/org/scudette/project/76f4d127-566b-42ef-86f4-bdcbc92b90b4?utm_source=github&utm_medium=referral&page=upgrade-pr","projectPublicId":"76f4d127-566b-42ef-86f4-bdcbc92b90b4","env":"prod","prType":"upgrade","vulns":[],"issuesToFix":[],"upgrade":[],"upgradeInfo":{"versionsDiff":1,"publishedDate":"2023-03-15T21:53:23.231Z"},"templateVariants":[],"hasFixes":false,"isMajorUpgrade":false,"isBreakingChange":false,"priorityScoreList":[]})
--->
Co-authored-by: snyk-bot <[email protected]>
scudette
pushed a commit
to Velocidex/velociraptor
that referenced
this pull request
May 31, 2023
<h3>Snyk has created this PR to upgrade recharts from 2.5.0 to
2.6.0.</h3>
:information_source: Keep your dependencies up-to-date. This makes it
easier to fix existing vulnerabilities and to more quickly identify and
fix newly disclosed vulnerabilities when they affect your project.
<hr/>
- The recommended version is **1 version** ahead of your current
version.
- The recommended version was released **22 days ago**, on 2023-05-08.
<details>
<summary><b>Release notes</b></summary>
<br/>
<details>
<summary>Package name: <b>recharts</b></summary>
<ul>
<li>
<b>2.6.0</b> - <a
href="https://snyk.io/redirect/github/recharts/recharts/releases/tag/v2.6.0">2023-05-08</a></br><h2>What's
Changed</h2>
<p>Storybook documentation updates as well as our first accessibility
feature thanks to <a class="user-mention notranslate"
data-hovercard-type="user"
data-hovercard-url="/users/julianna-langston/hovercard"
data-octo-click="hovercard-link-click"
data-octo-dimensions="link_type:self"
href="https://snyk.io/redirect/github/julianna-langston">@
julianna-langston</a> and some refactoring to function components!</p>
<h3>Feat</h3>
<ul>
<li>[a11y] Keyboard navigation support for categorical charts by <a
class="user-mention notranslate" data-hovercard-type="user"
data-hovercard-url="/users/julianna-langston/hovercard"
data-octo-click="hovercard-link-click"
data-octo-dimensions="link_type:self"
href="https://snyk.io/redirect/github/julianna-langston">@
julianna-langston</a> in <a class="issue-link js-issue-link"
data-error-text="Failed to load title" data-id="1679039594"
data-permission-text="Title is private"
data-url="recharts/recharts#3546"
data-hovercard-type="pull_request"
data-hovercard-url="/recharts/recharts/pull/3546/hovercard"
href="https://snyk.io/redirect/github/recharts/recharts/pull/3546">#3546</a>
<ul>
<li>See docs <a
href="https://release--63da8268a0da9970db6992aa.chromatic.com/?path=/docs/api-accessibility--docs"
rel="nofollow">here</a></li>
</ul>
</li>
</ul>
<h3>Fix</h3>
<ul>
<li>Update type for <code>equidistantPreserveStart</code> axis interval
by <a class="user-mention notranslate" data-hovercard-type="user"
data-hovercard-url="/users/frontier159/hovercard"
data-octo-click="hovercard-link-click"
data-octo-dimensions="link_type:self"
href="https://snyk.io/redirect/github/frontier159">@ frontier159</a> in
<a class="issue-link js-issue-link" data-error-text="Failed to load
title" data-id="1665853314" data-permission-text="Title is private"
data-url="recharts/recharts#3511"
data-hovercard-type="pull_request"
data-hovercard-url="/recharts/recharts/pull/3511/hovercard"
href="https://snyk.io/redirect/github/recharts/recharts/pull/3511">#3511</a></li>
<li>Stop focusing on tooltip when displayed - use event listeners
instead by <a class="user-mention notranslate"
data-hovercard-type="user"
data-hovercard-url="/users/ArkaFred/hovercard"
data-octo-click="hovercard-link-click"
data-octo-dimensions="link_type:self"
href="https://snyk.io/redirect/github/ArkaFred">@ ArkaFred</a> in <a
class="issue-link js-issue-link" data-error-text="Failed to load title"
data-id="1666576070" data-permission-text="Title is private"
data-url="recharts/recharts#3515"
data-hovercard-type="pull_request"
data-hovercard-url="/recharts/recharts/pull/3515/hovercard"
href="https://snyk.io/redirect/github/recharts/recharts/pull/3515">#3515</a></li>
</ul>
<h3>Docs</h3>
<ul>
<li>lots of storybook changes - <a
href="https://release--63da8268a0da9970db6992aa.chromatic.com/"
rel="nofollow">go check it out</a>!
<ul>
<li>Getting close to parity with existing docs on recharts.org</li>
<li>Added accessibility add-on</li>
<li>Added accessibility docs to go with the keyboard navigation
support</li>
<li>Storybook 7 stable</li>
<li>Much more!</li>
</ul>
</li>
</ul>
<h3>Refactor</h3>
<ul>
<li>refactor: <code>Curve</code> to function component by <a
class="user-mention notranslate" data-hovercard-type="user"
data-hovercard-url="/users/akamfoad/hovercard"
data-octo-click="hovercard-link-click"
data-octo-dimensions="link_type:self"
href="https://snyk.io/redirect/github/akamfoad">@ akamfoad</a> in <a
class="issue-link js-issue-link" data-error-text="Failed to load title"
data-id="1635746753" data-permission-text="Title is private"
data-url="recharts/recharts#3477"
data-hovercard-type="pull_request"
data-hovercard-url="/recharts/recharts/pull/3477/hovercard"
href="https://snyk.io/redirect/github/recharts/recharts/pull/3477">#3477</a></li>
<li>refactor: <code>PolarGrid</code> to function component by <a
class="user-mention notranslate" data-hovercard-type="user"
data-hovercard-url="/users/akamfoad/hovercard"
data-octo-click="hovercard-link-click"
data-octo-dimensions="link_type:self"
href="https://snyk.io/redirect/github/akamfoad">@ akamfoad</a> in <a
class="issue-link js-issue-link" data-error-text="Failed to load title"
data-id="1634552898" data-permission-text="Title is private"
data-url="recharts/recharts#3471"
data-hovercard-type="pull_request"
data-hovercard-url="/recharts/recharts/pull/3471/hovercard"
href="https://snyk.io/redirect/github/recharts/recharts/pull/3471">#3471</a></li>
<li>refactor: <code>Cross</code> to component function by <a
class="user-mention notranslate" data-hovercard-type="user"
data-hovercard-url="/users/akamfoad/hovercard"
data-octo-click="hovercard-link-click"
data-octo-dimensions="link_type:self"
href="https://snyk.io/redirect/github/akamfoad">@ akamfoad</a> in <a
class="issue-link js-issue-link" data-error-text="Failed to load title"
data-id="1635686265" data-permission-text="Title is private"
data-url="recharts/recharts#3475"
data-hovercard-type="pull_request"
data-hovercard-url="/recharts/recharts/pull/3475/hovercard"
href="https://snyk.io/redirect/github/recharts/recharts/pull/3475">#3475</a></li>
<li>refactor: tooltip to function component by <a class="user-mention
notranslate" data-hovercard-type="user"
data-hovercard-url="/users/ckifer/hovercard"
data-octo-click="hovercard-link-click"
data-octo-dimensions="link_type:self"
href="https://snyk.io/redirect/github/ckifer">@ ckifer</a> in <a
class="issue-link js-issue-link" data-error-text="Failed to load title"
data-id="1573765245" data-permission-text="Title is private"
data-url="recharts/recharts#3336"
data-hovercard-type="pull_request"
data-hovercard-url="/recharts/recharts/pull/3336/hovercard"
href="https://snyk.io/redirect/github/recharts/recharts/pull/3336">#3336</a></li>
<li>fix: defaultProps of tooltip, fix viewBox by <a class="user-mention
notranslate" data-hovercard-type="user"
data-hovercard-url="/users/ckifer/hovercard"
data-octo-click="hovercard-link-click"
data-octo-dimensions="link_type:self"
href="https://snyk.io/redirect/github/ckifer">@ ckifer</a> in <a
class="issue-link js-issue-link" data-error-text="Failed to load title"
data-id="1682527991" data-permission-text="Title is private"
data-url="recharts/recharts#3554"
data-hovercard-type="pull_request"
data-hovercard-url="/recharts/recharts/pull/3554/hovercard"
href="https://snyk.io/redirect/github/recharts/recharts/pull/3554">#3554</a></li>
<li>refactor: <code>Text</code> to function component by <a
class="user-mention notranslate" data-hovercard-type="user"
data-hovercard-url="/users/akamfoad/hovercard"
data-octo-click="hovercard-link-click"
data-octo-dimensions="link_type:self"
href="https://snyk.io/redirect/github/akamfoad">@ akamfoad</a> in <a
class="issue-link js-issue-link" data-error-text="Failed to load title"
data-id="1630235362" data-permission-text="Title is private"
data-url="recharts/recharts#3463"
data-hovercard-type="pull_request"
data-hovercard-url="/recharts/recharts/pull/3463/hovercard"
href="https://snyk.io/redirect/github/recharts/recharts/pull/3463">#3463</a></li>
</ul>
<h2>New Contributors</h2>
<ul>
<li><a class="user-mention notranslate" data-hovercard-type="user"
data-hovercard-url="/users/akamfoad/hovercard"
data-octo-click="hovercard-link-click"
data-octo-dimensions="link_type:self"
href="https://snyk.io/redirect/github/akamfoad">@ akamfoad</a> made
their first contribution in <a class="issue-link js-issue-link"
data-error-text="Failed to load title" data-id="1633414419"
data-permission-text="Title is private"
data-url="recharts/recharts#3466"
data-hovercard-type="pull_request"
data-hovercard-url="/recharts/recharts/pull/3466/hovercard"
href="https://snyk.io/redirect/github/recharts/recharts/pull/3466">#3466</a></li>
<li><a class="user-mention notranslate" data-hovercard-type="user"
data-hovercard-url="/users/nicholasgcoles/hovercard"
data-octo-click="hovercard-link-click"
data-octo-dimensions="link_type:self"
href="https://snyk.io/redirect/github/nicholasgcoles">@
nicholasgcoles</a> made their first contribution in <a class="issue-link
js-issue-link" data-error-text="Failed to load title"
data-id="1633478608" data-permission-text="Title is private"
data-url="recharts/recharts#3467"
data-hovercard-type="pull_request"
data-hovercard-url="/recharts/recharts/pull/3467/hovercard"
href="https://snyk.io/redirect/github/recharts/recharts/pull/3467">#3467</a></li>
<li><a class="user-mention notranslate" data-hovercard-type="user"
data-hovercard-url="/users/linhuiw/hovercard"
data-octo-click="hovercard-link-click"
data-octo-dimensions="link_type:self"
href="https://snyk.io/redirect/github/linhuiw">@ linhuiw</a> made their
first contribution in <a class="issue-link js-issue-link"
data-error-text="Failed to load title" data-id="1664182317"
data-permission-text="Title is private"
data-url="recharts/recharts#3508"
data-hovercard-type="pull_request"
data-hovercard-url="/recharts/recharts/pull/3508/hovercard"
href="https://snyk.io/redirect/github/recharts/recharts/pull/3508">#3508</a></li>
<li><a class="user-mention notranslate" data-hovercard-type="user"
data-hovercard-url="/users/frontier159/hovercard"
data-octo-click="hovercard-link-click"
data-octo-dimensions="link_type:self"
href="https://snyk.io/redirect/github/frontier159">@ frontier159</a>
made their first contribution in <a class="issue-link js-issue-link"
data-error-text="Failed to load title" data-id="1665853314"
data-permission-text="Title is private"
data-url="recharts/recharts#3511"
data-hovercard-type="pull_request"
data-hovercard-url="/recharts/recharts/pull/3511/hovercard"
href="https://snyk.io/redirect/github/recharts/recharts/pull/3511">#3511</a></li>
<li><a class="user-mention notranslate" data-hovercard-type="user"
data-hovercard-url="/users/ArkaFred/hovercard"
data-octo-click="hovercard-link-click"
data-octo-dimensions="link_type:self"
href="https://snyk.io/redirect/github/ArkaFred">@ ArkaFred</a> made
their first contribution in <a class="issue-link js-issue-link"
data-error-text="Failed to load title" data-id="1666576070"
data-permission-text="Title is private"
data-url="recharts/recharts#3515"
data-hovercard-type="pull_request"
data-hovercard-url="/recharts/recharts/pull/3515/hovercard"
href="https://snyk.io/redirect/github/recharts/recharts/pull/3515">#3515</a></li>
<li><a class="user-mention notranslate" data-hovercard-type="user"
data-hovercard-url="/users/julianna-langston/hovercard"
data-octo-click="hovercard-link-click"
data-octo-dimensions="link_type:self"
href="https://snyk.io/redirect/github/julianna-langston">@
julianna-langston</a> made their first contribution in <a
class="issue-link js-issue-link" data-error-text="Failed to load title"
data-id="1671964677" data-permission-text="Title is private"
data-url="recharts/recharts#3540"
data-hovercard-type="pull_request"
data-hovercard-url="/recharts/recharts/pull/3540/hovercard"
href="https://snyk.io/redirect/github/recharts/recharts/pull/3540">#3540</a></li>
</ul>
<p><strong>Full Changelog</strong>: <a class="commit-link"
href="https://snyk.io/redirect/github/recharts/recharts/compare/v2.5.0...v2.6.0"><tt>v2.5.0...v2.6.0</tt></a></p>
</li>
<li>
<b>2.5.0</b> - <a
href="https://snyk.io/redirect/github/recharts/recharts/releases/tag/v2.5.0">2023-03-15</a></br><h2>What's
Changed</h2>
<h3>Feat</h3>
<ul>
<li><code>ResponsiveContainer</code>: <code>onResize</code> callback
function by <a class="user-mention notranslate"
data-hovercard-type="user" data-hovercard-url="/users/ckifer/hovercard"
data-octo-click="hovercard-link-click"
data-octo-dimensions="link_type:self"
href="https://snyk.io/redirect/github/ckifer">@ ckifer</a> in <a
class="issue-link js-issue-link" data-error-text="Failed to load title"
data-id="1582916569" data-permission-text="Title is private"
data-url="recharts/recharts#3361"
data-hovercard-type="pull_request"
data-hovercard-url="/recharts/recharts/pull/3361/hovercard"
href="https://snyk.io/redirect/github/recharts/recharts/pull/3361">#3361</a></li>
<li><code>XAxis</code>, <code>YAxis</code>: <code>includeHidden</code>
prop - include all datapoints in domain calculation even when hidden by
<a class="user-mention notranslate" data-hovercard-type="user"
data-hovercard-url="/users/neefrehman/hovercard"
data-octo-click="hovercard-link-click"
data-octo-dimensions="link_type:self"
href="https://snyk.io/redirect/github/neefrehman">@ neefrehman</a> in <a
class="issue-link js-issue-link" data-error-text="Failed to load title"
data-id="1500101512" data-permission-text="Title is private"
data-url="recharts/recharts#3103"
data-hovercard-type="pull_request"
data-hovercard-url="/recharts/recharts/pull/3103/hovercard"
href="https://snyk.io/redirect/github/recharts/recharts/pull/3103">#3103</a></li>
<li><code>XAxis</code>, <code>YAxis</code>: new interval option
<code>equidistantPreserveStart</code> by <a class="user-mention
notranslate" data-hovercard-type="user"
data-hovercard-url="/users/nikolasrieble/hovercard"
data-octo-click="hovercard-link-click"
data-octo-dimensions="link_type:self"
href="https://snyk.io/redirect/github/nikolasrieble">@ nikolasrieble</a>
in <a class="issue-link js-issue-link" data-error-text="Failed to load
title" data-id="1594785191" data-permission-text="Title is private"
data-url="recharts/recharts#3392"
data-hovercard-type="pull_request"
data-hovercard-url="/recharts/recharts/pull/3392/hovercard"
href="https://snyk.io/redirect/github/recharts/recharts/pull/3392">#3392</a></li>
</ul>
<h3>Fix</h3>
<ul>
<li><code>ResponsiveContainer</code>: default min-width to 0 to override
default auto behavior that breaks flexbox layouts by <a
class="user-mention notranslate" data-hovercard-type="user"
data-hovercard-url="/users/ckifer/hovercard"
data-octo-click="hovercard-link-click"
data-octo-dimensions="link_type:self"
href="https://snyk.io/redirect/github/ckifer">@ ckifer</a> in <a
class="issue-link js-issue-link" data-error-text="Failed to load title"
data-id="1594523953" data-permission-text="Title is private"
data-url="recharts/recharts#3391"
data-hovercard-type="pull_request"
data-hovercard-url="/recharts/recharts/pull/3391/hovercard"
href="https://snyk.io/redirect/github/recharts/recharts/pull/3391">#3391</a></li>
<li><code>Area</code>: Add missing 'data' type to Area component by <a
class="user-mention notranslate" data-hovercard-type="user"
data-hovercard-url="/users/ondrejvelisek/hovercard"
data-octo-click="hovercard-link-click"
data-octo-dimensions="link_type:self"
href="https://snyk.io/redirect/github/ondrejvelisek">@ ondrejvelisek</a>
in <a class="issue-link js-issue-link" data-error-text="Failed to load
title" data-id="1615470205" data-permission-text="Title is private"
data-url="recharts/recharts#3443"
data-hovercard-type="pull_request"
data-hovercard-url="/recharts/recharts/pull/3443/hovercard"
href="https://snyk.io/redirect/github/recharts/recharts/pull/3443">#3443</a></li>
<li><code>Brush</code>/<code>XAxis</code>: fix NaN regression when
<code>interval={0}</code> by <a class="user-mention notranslate"
data-hovercard-type="user"
data-hovercard-url="/users/nikolasrieble/hovercard"
data-octo-click="hovercard-link-click"
data-octo-dimensions="link_type:self"
href="https://snyk.io/redirect/github/nikolasrieble">@ nikolasrieble</a>
in <a class="issue-link js-issue-link" data-error-text="Failed to load
title" data-id="1622213441" data-permission-text="Title is private"
data-url="recharts/recharts#3454"
data-hovercard-type="pull_request"
data-hovercard-url="/recharts/recharts/pull/3454/hovercard"
href="https://snyk.io/redirect/github/recharts/recharts/pull/3454">#3454</a></li>
<li><code>ReferenceArea</code>/<code>ReferenceLine</code>: revert
regression where <code>ifOverflow</code> prop is not obeyed due to
missing defaultProps by <a class="user-mention notranslate"
data-hovercard-type="user" data-hovercard-url="/users/ckifer/hovercard"
data-octo-click="hovercard-link-click"
data-octo-dimensions="link_type:self"
href="https://snyk.io/redirect/github/ckifer">@ ckifer</a> in <a
class="issue-link js-issue-link" data-error-text="Failed to load title"
data-id="1622808868" data-permission-text="Title is private"
data-url="recharts/recharts#3455"
data-hovercard-type="pull_request"
data-hovercard-url="/recharts/recharts/pull/3455/hovercard"
href="https://snyk.io/redirect/github/recharts/recharts/pull/3455">#3455</a></li>
</ul>
<h3>Docs</h3>
<ul>
<li>lots of storybook changes - <a
href="https://master--63da8268a0da9970db6992aa.chromatic.com/"
rel="nofollow">go check it out</a>!</li>
</ul>
<h3>Dependencies</h3>
<ul>
<li>chore: explicitly upgrade minor version of react-smooth by <a
class="user-mention notranslate" data-hovercard-type="user"
data-hovercard-url="/users/ckifer/hovercard"
data-octo-click="hovercard-link-click"
data-octo-dimensions="link_type:self"
href="https://snyk.io/redirect/github/ckifer">@ ckifer</a> in <a
class="issue-link js-issue-link" data-error-text="Failed to load title"
data-id="1597775617" data-permission-text="Title is private"
data-url="recharts/recharts#3397"
data-hovercard-type="pull_request"
data-hovercard-url="/recharts/recharts/pull/3397/hovercard"
href="https://snyk.io/redirect/github/recharts/recharts/pull/3397">#3397</a></li>
<li>chore: upgrade react-resize-detector to 8.x by <a
class="user-mention notranslate" data-hovercard-type="user"
data-hovercard-url="/users/ckifer/hovercard"
data-octo-click="hovercard-link-click"
data-octo-dimensions="link_type:self"
href="https://snyk.io/redirect/github/ckifer">@ ckifer</a> in <a
class="issue-link js-issue-link" data-error-text="Failed to load title"
data-id="1607429776" data-permission-text="Title is private"
data-url="recharts/recharts#3418"
data-hovercard-type="pull_request"
data-hovercard-url="/recharts/recharts/pull/3418/hovercard"
href="https://snyk.io/redirect/github/recharts/recharts/pull/3418">#3418</a></li>
</ul>
<h3>Refactor</h3>
<ul>
<li>Refactoring: Adapt getTicks to increase reusability of code by <a
class="user-mention notranslate" data-hovercard-type="user"
data-hovercard-url="/users/nikolasrieble/hovercard"
data-octo-click="hovercard-link-click"
data-octo-dimensions="link_type:self"
href="https://snyk.io/redirect/github/nikolasrieble">@ nikolasrieble</a>
in <a class="issue-link js-issue-link" data-error-text="Failed to load
title" data-id="1595050186" data-permission-text="Title is private"
data-url="recharts/recharts#3393"
data-hovercard-type="pull_request"
data-hovercard-url="/recharts/recharts/pull/3393/hovercard"
href="https://snyk.io/redirect/github/recharts/recharts/pull/3393">#3393</a></li>
<li>Refactoring: Extract TicksUtils from CartesianAxis and add unit
tests by <a class="user-mention notranslate" data-hovercard-type="user"
data-hovercard-url="/users/nikolasrieble/hovercard"
data-octo-click="hovercard-link-click"
data-octo-dimensions="link_type:self"
href="https://snyk.io/redirect/github/nikolasrieble">@ nikolasrieble</a>
in <a class="issue-link js-issue-link" data-error-text="Failed to load
title" data-id="1593521268" data-permission-text="Title is private"
data-url="recharts/recharts#3386"
data-hovercard-type="pull_request"
data-hovercard-url="/recharts/recharts/pull/3386/hovercard"
href="https://snyk.io/redirect/github/recharts/recharts/pull/3386">#3386</a></li>
</ul>
<h2>New Contributors</h2>
<ul>
<li><a class="user-mention notranslate" data-hovercard-type="user"
data-hovercard-url="/users/ondrejvelisek/hovercard"
data-octo-click="hovercard-link-click"
data-octo-dimensions="link_type:self"
href="https://snyk.io/redirect/github/ondrejvelisek">@ ondrejvelisek</a>
made their first contribution in <a class="issue-link js-issue-link"
data-error-text="Failed to load title" data-id="1615470205"
data-permission-text="Title is private"
data-url="recharts/recharts#3443"
data-hovercard-type="pull_request"
data-hovercard-url="/recharts/recharts/pull/3443/hovercard"
href="https://snyk.io/redirect/github/recharts/recharts/pull/3443">#3443</a></li>
</ul>
<p><strong>Full Changelog</strong>: <a class="commit-link"
href="https://snyk.io/redirect/github/recharts/recharts/compare/v2.4.3...v2.5.0"><tt>v2.4.3...v2.5.0</tt></a></p>
</li>
</ul>
from <a
href="https://snyk.io/redirect/github/recharts/recharts/releases">recharts
GitHub release notes</a>
</details>
</details>
<details>
<summary><b>Commit messages</b></summary>
</br>
<details>
<summary>Package name: <b>recharts</b></summary>
<ul>
<li><a
href="https://snyk.io/redirect/github/recharts/recharts/commit/97e263529ed2d4b2d92a3190cd58e53cf8643e94">97e2635</a>
2.6.0</li>
<li><a
href="https://snyk.io/redirect/github/recharts/recharts/commit/f6767977da79f456fc02c9a1e4336213615a66e5">f676797</a>
chore: upgrade storybook to latest (#3570)</li>
<li><a
href="https://snyk.io/redirect/github/recharts/recharts/commit/1e7618343aa7c1ace1c30d1b4ca4df24f1c9f466">1e76183</a>
refactor: `PolarGrid` to function component (#3471)</li>
<li><a
href="https://snyk.io/redirect/github/recharts/recharts/commit/37e1c64005ea5b9dba341ef6db806a4736de7550">37e1c64</a>
refactor: `Curve` to function component (#3477)</li>
<li><a
href="https://snyk.io/redirect/github/recharts/recharts/commit/7eabe344c3cb49c1a45bddd436731621dae7e4aa">7eabe34</a>
Storybook: Add Curve API stories and doc (#3566)</li>
<li><a
href="https://snyk.io/redirect/github/recharts/recharts/commit/ba86ca93e6fbcfdcf7c90bd285f0b5a42ec41772">ba86ca9</a>
refactor: `Cross` to component function (#3475)</li>
<li><a
href="https://snyk.io/redirect/github/recharts/recharts/commit/09985ef90adcb4ac23209f4844565931851d2884">09985ef</a>
[a11y] Keyboard navigation support for categorical charts (#3546)</li>
<li><a
href="https://snyk.io/redirect/github/recharts/recharts/commit/3eac95aca94fc350ba89687dd96a8f9a633cbf31">3eac95a</a>
Storybook: Add Scatter API documentation (#3560)</li>
<li><a
href="https://snyk.io/redirect/github/recharts/recharts/commit/f9dc04c7f8ca7d464193e1460aa0fdd973943f15">f9dc04c</a>
Storybook: Add ArgsTable with description per prop to BAR component
(#3558)</li>
<li><a
href="https://snyk.io/redirect/github/recharts/recharts/commit/de3c046f37ba3ff68b71244cab19d0bce07a8bd5">de3c046</a>
fix: defaultProps of tooltip, fix viewBox (#3554)</li>
<li><a
href="https://snyk.io/redirect/github/recharts/recharts/commit/a651f2cc5fad913853c8a6704ea62416742f26e3">a651f2c</a>
fix(storybook): delay snapshot tests past animation time for consiste…
(#3550)</li>
<li><a
href="https://snyk.io/redirect/github/recharts/recharts/commit/0b231b703bc7636795e4667c4b0db86b76eb26a6">0b231b7</a>
refactor: tooltip to function component (#3336)</li>
<li><a
href="https://snyk.io/redirect/github/recharts/recharts/commit/e0f7d52f613df3f1c1b8c2e75cc271f92bdec76c">e0f7d52</a>
Storybook: adjust arg table of ReferenceLine (#3530)</li>
<li><a
href="https://snyk.io/redirect/github/recharts/recharts/commit/a32f1ee85ecae4ccf18cd3352f164a707c737f03">a32f1ee</a>
fix: cross storybook build (#3543)</li>
<li><a
href="https://snyk.io/redirect/github/recharts/recharts/commit/59669871ba1806f121960df2f0ef2be690c964b1">5966987</a>
Add storybook examples for charts with fill patterns (#3541)</li>
<li><a
href="https://snyk.io/redirect/github/recharts/recharts/commit/1720700034b51bf319e96a78c014356beea4b8a8">1720700</a>
Storybook: Add story for Cross (#3539)</li>
<li><a
href="https://snyk.io/redirect/github/recharts/recharts/commit/3da03cf176519d4b4aa60ca370a607848d67ed51">3da03cf</a>
Address React syntax error message on Storybook welcome page
(#3540)</li>
<li><a
href="https://snyk.io/redirect/github/recharts/recharts/commit/1058d1ca6850c3b38db73f9e23769996f0eb92a4">1058d1c</a>
Storybook: add accessibility addon (#3535)</li>
<li><a
href="https://snyk.io/redirect/github/recharts/recharts/commit/7cf9fbc2215e0d3d5efe80e37fdd724a60e4bb84">7cf9fbc</a>
Storybook: add args table to `CartesianAxis` (#3514)</li>
<li><a
href="https://snyk.io/redirect/github/recharts/recharts/commit/d043fc4045da1a047c6dffe399683bde7620b6d0">d043fc4</a>
Storybook: Improve ArgsTables of api/chart stories (#3534)</li>
<li><a
href="https://snyk.io/redirect/github/recharts/recharts/commit/c6aeae53a3a97b68028475a7e1c035e1f8eb2a0e">c6aeae5</a>
Storybook: Upgrade to 7.0.5 (#3531)</li>
<li><a
href="https://snyk.io/redirect/github/recharts/recharts/commit/77b7083b71f98fcda828f6d7da3ff9fae788ee33">77b7083</a>
Storybook: add args table to `ComposedChart` (#3518)</li>
<li><a
href="https://snyk.io/redirect/github/recharts/recharts/commit/b9acdb148a5076e5208a06e8358bf504467aa2ca">b9acdb1</a>
Storybook: add args table to `LineChart` (#3521)</li>
<li><a
href="https://snyk.io/redirect/github/recharts/recharts/commit/84664411421c132b6f537800ed58941a9688254b">8466441</a>
Storybook: add args table to `RadarBarChart` (#3524)</li>
</ul>
<a
href="https://snyk.io/redirect/github/recharts/recharts/compare/3e31520ce0a71dc48532f996900250396a135bcd...97e263529ed2d4b2d92a3190cd58e53cf8643e94">Compare</a>
</details>
</details>
<hr/>
**Note:** *You are seeing this because you or someone else with access
to this repository has authorized Snyk to open upgrade PRs.*
For more information: <img
src="https://api.segment.io/v1/pixel/track?data=eyJ3cml0ZUtleSI6InJyWmxZcEdHY2RyTHZsb0lYd0dUcVg4WkFRTnNCOUEwIiwiYW5vbnltb3VzSWQiOiI4ODM0YmI0Mi0xNzJkLTQxZGMtOGI2NC1lNTNlNGVlMDVkNGEiLCJldmVudCI6IlBSIHZpZXdlZCIsInByb3BlcnRpZXMiOnsicHJJZCI6Ijg4MzRiYjQyLTE3MmQtNDFkYy04YjY0LWU1M2U0ZWUwNWQ0YSJ9fQ=="
width="0" height="0"/>
🧐 [View latest project
report](https://app.snyk.io/org/scudette/project/76f4d127-566b-42ef-86f4-bdcbc92b90b4?utm_source=github&utm_medium=referral&page=upgrade-pr)
🛠 [Adjust upgrade PR
settings](https://app.snyk.io/org/scudette/project/76f4d127-566b-42ef-86f4-bdcbc92b90b4/settings/integration?utm_source=github&utm_medium=referral&page=upgrade-pr)
🔕 [Ignore this dependency or unsubscribe from future upgrade
PRs](https://app.snyk.io/org/scudette/project/76f4d127-566b-42ef-86f4-bdcbc92b90b4/settings/integration?pkg=recharts&utm_source=github&utm_medium=referral&page=upgrade-pr#auto-dep-upgrades)
<!---
(snyk:metadata:{"prId":"8834bb42-172d-41dc-8b64-e53e4ee05d4a","prPublicId":"8834bb42-172d-41dc-8b64-e53e4ee05d4a","dependencies":[{"name":"recharts","from":"2.5.0","to":"2.6.0"}],"packageManager":"npm","type":"auto","projectUrl":"https://app.snyk.io/org/scudette/project/76f4d127-566b-42ef-86f4-bdcbc92b90b4?utm_source=github&utm_medium=referral&page=upgrade-pr","projectPublicId":"76f4d127-566b-42ef-86f4-bdcbc92b90b4","env":"prod","prType":"upgrade","vulns":[],"issuesToFix":[],"upgrade":[],"upgradeInfo":{"versionsDiff":1,"publishedDate":"2023-05-08T21:55:01.618Z"},"templateVariants":[],"hasFixes":false,"isMajorUpgrade":false,"isBreakingChange":false,"priorityScoreList":[]})
--->
](https://renovatebot.com){kind=link}
1 task
7 tasks
ckifer
added a commit
that referenced
this pull request
Apr 18, 2024
<!--- Provide a general summary of your changes in the Title above --> ## Description <!--- Describe your changes in detail --> Bug reported in linked issue where after recharts 2.5 the YAxis line would "disappear" with 0 data points or ticks, where it would previously show. It would previously show because `NaN` was being calculated as a tick value and added to the dom as a tick item. This was fixed in #3454. I would not call this a regression because as per the lines changed in this PR, the axis lines were never meant to show unless there were ticks. (See `!finalTicks || !finalTicks.length`). I believe however, that they should be able to. Thus, this is a breaking change for both X and Y axes where even with 0 ticks or 0 valid data items, the axis lines will still render. For a user to return to the old behavior of no Axis, they only have to do something simple like `YAxis hide={data.length === 0} />` or use React convention and conditionally render it ## Related Issue <!--- This project only accepts pull requests related to open issues --> <!--- If suggesting a new feature or change, please discuss it in an issue first --> <!--- If fixing a bug, there should be an issue describing it with steps to reproduce --> <!--- Please link to the issue here: --> #4426 ## Motivation and Context <!--- Why is this change required? What problem does it solve? --> - It makes sense to show an axis line even when there are no ticks ## How Has This Been Tested? <!--- Please describe in detail how you tested your changes. --> <!--- Include details of your testing environment, and the tests you ran to --> <!--- see how your change affects other areas of the code, etc. --> - unit tests - see screenshot ## Screenshots (if appropriate): <img width="864" alt="image" src="https://github.com/recharts/recharts/assets/25180830/c10295ea-a30c-481c-b313-2ca4936dc3d4"> ## Types of changes <!--- What types of changes does your code introduce? Put an `x` in all the boxes that apply: --> - [X] Bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [X] Breaking change (fix or feature that would cause existing functionality to change) ## Checklist: <!--- Go over all the following points, and put an `x` in all the boxes that apply. --> <!--- If you're unsure about any of these, don't hesitate to ask. We're here to help! --> - [ ] My change requires a change to the documentation. - [ ] I have updated the documentation accordingly. - [X] I have added tests to cover my changes. - [ ] I have added a storybook story or extended an existing story to show my changes Co-authored-by: Coltin Kifer <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Description of the issue is found here. #3447 (comment)
The solution is simple:
Filter all ticks that have NaN as a coordinate.
This PR additionally adds unit tests and a few comments.
Related Issue
#3447
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: