chore: use early return to improve readability of getAxisMapByAxes#3107
Merged
ckifer merged 1 commit intoDec 23, 2022
Merged
Conversation
ckifer
approved these changes
Dec 20, 2022
ckifer
left a comment
ckifer
left a comment
Member
There was a problem hiding this comment.
Changes look good to me. Just shifting inverting the return logic which is safe here.
We need to add unit tests to generateCategoricalChart but I don't think this PR should be responsible for that. It does get tested via other tests (since every categorical chart calls it and every one with an XAxis calls this specifically).
ckifer
added
P1
Member
|
I pulled this down locally just to do some testing. This early return isn't ever reached in any of the recharts demos - inversion looks safe to merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-on from #3103
I've made a change to
getAxisMapByAxesingenerateCategoricalChart.tsx, to do an early return in theaxes.reducecall when we have cached data in the accumulator, instead of at the end. This reduces the nesting of code to improve readability. It also avoids the function having to callgetDisplayedDatawhen not necessary—which also iterates over a list—to give a potential performance improvement if there are ever duplicatedaxisIdKeys.