Skip to content

Sankey - removed accessibilityLayer? #7151

Description

@ldeveber

What is the current behavior?

The following code worked in 3.6.0 but not 3.7.0 or 3.8.0:

<Sankey
  accessibilityLayer
  data={data}
  iterations={iterations}
  link={Link}
  node={Node}
  title="Example"
>
    // ...
</Sankey>

This used to add <title>Example</title> in the SVG but no longer does. Additionally, the following errors happen on compilation:

♥ ❯ pnpm tsc
components/count/MapChart.tsx:362:15 - error TS2322: Type '{ children: Element[]; accessibilityLayer: true; data: { nodes: NodeDataItem[]; links: LinkDataItem[]; }; iterations: number; link: ({ sourceX, targetX, sourceY, targetY, sourceControlX, targetControlX, linkWidth, index, payload: { source, target }, }: LinkProps) => Element; node: ({ x, y, width, height, index, payl...' is not assignable to type 'IntrinsicAttributes & SVGProps<SVGSVGElement> & SankeyProps'.
  Property 'accessibilityLayer' does not exist on type 'IntrinsicAttributes & SVGProps<SVGSVGElement> & SankeyProps'.

362               accessibilityLayer
                  ~~~~~~~~~~~~~~~~~~

components/count/MapChart.tsx:367:15 - error TS2322: Type '{ children: Element[]; data: { nodes: NodeDataItem[]; links: LinkDataItem[]; }; iterations: number; link: ({ sourceX, targetX, sourceY, targetY, sourceControlX, targetControlX, linkWidth, index, payload: { source, target }, }: LinkProps) => Element; node: ({ x, y, width, height, index, payload }: NodeProps) => Eleme...' is not assignable to type 'IntrinsicAttributes & SVGProps<SVGSVGElement> & SankeyProps'.
  Property 'title' does not exist on type 'IntrinsicAttributes & SVGProps<SVGSVGElement> & SankeyProps'.

367               title="Example"
                  ~~~~~


Found 2 errors in components/count/MapChart.tsx:362


❯       

What is the expected behavior?

Expected <title>Example</title> to be present like in the other charts. I'm not sure if any of the other accessibility parts were working before, because I hadn't gotten that far in implementing it in my usage of Sankey 😅

Please provide a demo of the problem in a sandbox

https://stackblitz.com/edit/lbje6c2j?file=src%2FExample.tsx

Which versions of Recharts, and which browser / OS are affected by this issue? Did this work in previous versions of Recharts?

Worked in 3.6.0, did not work in 3.7.0 or 3.8.0

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions