…hape` prop (recharts#7067) ## Description PR recharts#6800 introduced zero-dimension bar filtering for perf (skip rendering `width === 0 || height === 0` bars). This broke the BoxPlot pattern, which uses zero-height stacked bars with a custom `shape` prop to render horizontal line markers at stack positions. ### Changes - **`src/state/types/BarSettings.ts`**: Added `hasCustomShape: boolean` to `BarSettings` - **`src/cartesian/Bar.tsx`** (registration): Passes `hasCustomShape={props.shape != null}` into Redux state when Bar mounts - **`src/cartesian/Bar.tsx`** (`computeBarRectangles`): Zero-dimension filter now skips bars with a custom shape — they may still produce visible output even at zero height/width ```tsx // BoxPlot pattern: zero-height bar, but shape renders a line at that y position <Bar stackId="a" dataKey="marker" shape={<HorizonBar />} /> // Previously filtered out by width===0||height===0; now preserved when shape is set ``` - Updated all `BarSettings` snapshots across 8+ test files to include `hasCustomShape: false` - Added test case in `Bar.zeroDimensionFiltering.spec.tsx` asserting custom-shape zero-height bars are not filtered ## Related Issue https://github.com/recharts/recharts/issues/  ## Motivation and Context The BoxPlot storybook example went blank after recharts#6800. Zero-height bars are a legitimate pattern when a custom `shape` handles rendering — the bar coordinates are still needed for positioning. ## How Has This Been Tested? - New unit test: `should not filter out zero-height bars that have a custom shape (BoxPlot use case)` — verifies all data points produce a `BarRectangleItem` with `height === 0` instead of being dropped - Full test suite: 286 test files, 14 105 tests pass - TypeScript: `tsc --noEmit` clean across `src/`, `test/`, and `storybook/` ## Screenshots (if appropriate): N/A (storybook visual regression covers this via Chromatic) ## Types of changes - [x] Bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to change) ## Checklist: - [ ] My change requires a change to the documentation. - [ ] I have updated the documentation accordingly. - [x] I have added tests to cover my changes. - [ ] I have added a storybook story or VR test, or extended an existing story or VR test to show my changes  <details> <summary>Original prompt</summary> > > ---- > > *This section details on the original issue you should resolve* > > <issue_title>[Unreleased] Missing error bars in BoxPlot example</issue_title> > <issue_description>https://www.chromatic.com/test?appId=63da8268a0da9970db6992aa&id=69a18bb251ba943c7ece0737 > > Must be from some recent PR</issue_description> > > ## Comments on the Issue (you are @copilot in this section) > > <comments> > <comment_new><author>@PavelVanecek</author><body> > Hm it's recharts#6800 > > Perf improvement is nice but it erases zero-height bars which we used to fake boxplot.</body></comment_new> > <comment_new><author>@ckifer</author><body> > Hmmmmm. Gotta fix before release I suppose. Revert the filter? Something else?</body></comment_new> > <comment_new><author>@ckifer</author><body> > Probably revert and add explicit box plot support later? Then can filter when not doing box plot?</body></comment_new> > <comment_new><author>@PavelVanecek</author><body> > Or render bars that have nonzero stroke width </body></comment_new> > </comments> > </details>  - Fixes recharts#7064  --- 💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more [Copilot coding agent tips](https://gh.io/copilot-coding-agent-tips) in the docs.  ## Summary by CodeRabbit * **New Features** * Custom-shaped bars now render correctly with zero dimensions, enabling expanded visualization customization options for bar charts. * **Tests** * Updated test coverage for custom-shaped bar rendering behavior.  --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: PavelVanecek <1100170+PavelVanecek@users.noreply.github.com>

Uh oh!

Uh oh!

[Unreleased] Missing error bars in BoxPlot example #7064

Description

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions