Skip to content

[3.4.1] type errors with current release when skipLibCheck: false #6664

Description

@AviVahl

What is the current behavior?

When type checking a project without skipLibCheck, I see the following errors coming from recharts:

node_modules/recharts/types/state/selectors/axisSelectors.d.ts:145:74 - error TS2694: Namespace '"/home/avi/projects/recharts-type-issue/node_modules/redux/dist/redux"' has no exported member 'EmptyObject'.

145 export declare const selectDomainOfStackGroups: ((state: import("redux").EmptyObject & {
                                                                             ~~~~~~~~~~~

node_modules/recharts/types/state/selectors/axisSelectors.d.ts:213:74 - error TS2694: Namespace '"/home/avi/projects/recharts-type-issue/node_modules/redux/dist/redux"' has no exported member 'EmptyObject'.

213 export declare const selectReferenceDotsByAxis: ((state: import("redux").EmptyObject & {
                                                                             ~~~~~~~~~~~

node_modules/recharts/types/state/selectors/axisSelectors.d.ts:309:72 - error TS2694: Namespace '"/home/avi/projects/recharts-type-issue/node_modules/redux/dist/redux"' has no exported member 'EmptyObject'.

309 export declare const selectErrorBarsSettings: ((state: import("redux").EmptyObject & {
                                                                           ~~~~~~~~~~~

node_modules/recharts/types/state/selectors/axisSelectors.d.ts:384:100 - error TS2694: Namespace '"/home/avi/projects/recharts-type-issue/node_modules/redux/dist/redux"' has no exported member 'EmptyObject'.

384 export declare const selectAxisPropsNeededForCartesianGridTicksGenerator: ((state: import("redux").EmptyObject & {
                                                                                                       ~~~~~~~~~~~

node_modules/recharts/types/state/selectors/axisSelectors.d.ts:458:69 - error TS2694: Namespace '"/home/avi/projects/recharts-type-issue/node_modules/redux/dist/redux"' has no exported member 'EmptyObject'.

458 export declare const selectZAxisWithScale: ((state: import("redux").EmptyObject & {
                                                                        ~~~~~~~~~~~

node_modules/recharts/types/state/store.d.ts:2:68 - error TS2694: Namespace '"/home/avi/projects/recharts-type-issue/node_modules/redux/dist/redux"' has no exported member 'CombinedState'.

2 declare const rootReducer: import("redux").Reducer<import("redux").CombinedState<{
                                                                     ~~~~~~~~~~~~~


Found 6 errors in 2 files.

Errors  Files
     5  node_modules/recharts/types/state/selectors/axisSelectors.d.ts:145
     1  node_modules/recharts/types/state/store.d.ts:2

What is the expected behavior?

No type errors. These can cause any to slip into otherwise well-typed library.

Please provide a demo of the problem in a sandbox

Can be reproduced by running the following project creation steps:

mkdir recharts-type-issue
cd recharts-type-issue
npm init -y
npm pkg set type=module
npm i recharts typescript @types/react
npx tsc --init --skipLibCheck false --exactOptionalPropertyTypes false
echo "import * as recharts from 'recharts'; console.log(recharts);" > main.ts
npx tsc --noEmit

Which versions of Recharts, and which browser / OS are affected by this issue? Did this work in previous versions of Recharts?

[email protected] on all platforms.

Metadata

Metadata

Assignees

Labels

typescriptPRs or Issues surrounding Types or TS refactoring

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions