Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: recharts/recharts
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v2.6.0
Choose a base ref
...
head repository: recharts/recharts
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v2.6.1
Choose a head ref
  • 3 commits
  • 7 files changed
  • 2 contributors

Commits on May 8, 2023

  1. docs: update readme

    Coltin Kifer
    Coltin Kifer committed May 8, 2023
    Configuration menu
    Copy the full SHA
    68dbe57 View commit details
    Browse the repository at this point in the history

Commits on May 10, 2023

  1. Configuration menu
    Copy the full SHA
    aa3bbbd View commit details
    Browse the repository at this point in the history
  2. Fix treemap tooltip crash (#3579)

    <!--- Provide a general summary of your changes in the Title above -->
    
    ## Description
    
    <!--- Describe your changes in detail -->
    Bug released in 2.6 with refactor of Tooltip to a function component.
    Add optionals to prevent crashing when `coordinate` is `null`.
    
    This resulted in other errors surrounding event pooling
    https://legacy.reactjs.org/docs/legacy-event-pooling.html
    
    This isn't an issue in React 17+ but throws errors in react <17 so call
    e.persist() in the offending functions in `Treemap` - this resolves
    errors in React 16 and has no effect in React 17 (see
    https://legacy.reactjs.org/blog/2020/08/10/react-v17-rc.html#no-event-pooling)
    
    ## Related Issue
    #3578
    <!--- This project only accepts pull requests related to open issues -->
    <!--- If suggesting a new feature or change, please discuss it in an
    issue first -->
    <!--- If fixing a bug, there should be an issue describing it with steps
    to reproduce -->
    <!--- Please link to the issue here: -->
    
    ## Motivation and Context
    
    <!--- Why is this change required? What problem does it solve? -->
    Fix 2.6.0 bug #3578
    
    ## How Has This Been Tested?
    
    <!--- Please describe in detail how you tested your changes. -->
    <!--- Include details of your testing environment, and the tests you ran
    to -->
    <!--- see how your change affects other areas of the code, etc. -->
    - Create new treemap story to reproduce bug from
    #3578
    - Ensure bug has been fixed
    
    ## Screenshots (if appropriate):
    <img width="553" alt="image"
    src="https://github.com/recharts/recharts/assets/25180830/c4dd313b-4214-4ff7-b152-262e3862a6cf">
    
    
    ## Types of changes
    
    <!--- What types of changes does your code introduce? Put an `x` in all
    the boxes that apply: -->
    
    - [X] Bug fix (non-breaking change which fixes an issue)
    - [ ] New feature (non-breaking change which adds functionality)
    - [ ] Breaking change (fix or feature that would cause existing
    functionality to change)
    
    ## Checklist:
    
    <!--- Go over all the following points, and put an `x` in all the boxes
    that apply. -->
    <!--- If you're unsure about any of these, don't hesitate to ask. We're
    here to help! -->
    
    - [X] My code follows the code style of this project.
    - [ ] My change requires a change to the documentation.
    - [ ] I have updated the documentation accordingly.
    - [ ] I have added tests to cover my changes.
    - [X] All new and existing tests passed.
    
    ---------
    
    Co-authored-by: Coltin Kifer <[email protected]>
    ckifer and Coltin Kifer authored May 10, 2023
    Configuration menu
    Copy the full SHA
    cfa141d View commit details
    Browse the repository at this point in the history
Loading