Skip to content

Upgrade dependencies#72

Merged
arcthur merged 2 commits into
recharts:masterfrom
ckifer:master
Feb 24, 2023
Merged

Upgrade dependencies#72
arcthur merged 2 commits into
recharts:masterfrom
ckifer:master

Conversation

@ckifer

@ckifer ckifer commented Feb 23, 2023

Copy link
Copy Markdown
Member

This library is in need of some dependency upgrades (see dependabot PRs) to stay up to date and to prepare for upgrading react-transition-group and dropping support for react < 16.8. This is a release candidate for 2.0.2.

Note:

  • don't upgrade react-transition-group in minor release as this requires dropping support for react <16.6

Tests are passing - linter is not. It wasn't before either.

Also released this to my personal NPM to test in recharts - https://www.npmjs.com/package/ckifer-react-smooth

  • builds, tests, and runs without issue in current recharts repo

@Semigradsky

Copy link
Copy Markdown
Contributor

Just a suggestion: replace fast-equals to fast-deep-equal to potentially decrease count of dependencies.
For example my project already has fast-deep-equal from eslint, ajv, bonjour-service (webpack-dev-server dependency)

@ckifer

ckifer commented Feb 24, 2023

Copy link
Copy Markdown
Member Author

Maybe makes sense to do before releasing the next major version yeah.
But you're right fast-deep-equals is much more used/popular.

For now I was just cleaning up dependencies so things are up to date. Feel free to make a PR if you'd like to replace it!

@Semigradsky

Copy link
Copy Markdown
Contributor

I rechecked packages and maybe switch to fast-deep-equal is not good decision. fast-equals is better maintained and has no problems with objects with null prototype. Potentially fast-equals is better choise.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants