Skip to content

Conversation

@stermeau
Copy link
Contributor

No description provided.

@jsmeix jsmeix added the bug The code does not do what it is meant to do label Aug 26, 2016
@jsmeix
Copy link
Member

jsmeix commented Aug 26, 2016

@stermeau
could you please provide sufficiently explanatory comments
directly in the code so that others who may at any time later
have to maintain that code can understand why that code is
as it is, cf. https://github.com/rear/rear/wiki/Coding-Style

FYI:
Fortunately for me personally it is no issue how code
for third-party backup tools is because I do not have
such tools so that I will never ever personally care about
that code (cf. #823).
But probably other users who use such tools may appreciate it
when they can maintain the existing code properly if needed.

@jsmeix jsmeix added minor bug An alternative or workaround exists and removed bug The code does not do what it is meant to do labels Aug 26, 2016
@stermeau
Copy link
Contributor Author

@jsmeix I have added some comments. Is it what you had in mind?

@gdha gdha merged commit 04ebe5f into rear:master Aug 29, 2016
@gdha gdha added this to the Rear v1.19 milestone Aug 31, 2016
@jsmeix
Copy link
Member

jsmeix commented Sep 15, 2016

@stermeau
many thanks for your added comments in the code.
At least for me it makes the code much easier to understand!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fixed / solved / done minor bug An alternative or workaround exists

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants