-
-
Notifications
You must be signed in to change notification settings - Fork 268
USE_STATIC_NETWORKING now really overrides USE_DHCLIENT. #964
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Before even if set, dhcp configuration was used in rear recover.
|
@gozora I think prep/GNU/Linux/21_include_dhclient.sh is meant I think USE_STATIC_NETWORKING is not meant In short - I would expect that with USE_DHCLIENT="yes" USE_STATIC_NETWORKING="yes" I get a dhclient binary in the recovery system I think you need to fix it in the system-setup setup scripts I guess therein the [[ -z "$USE_DHCLIENT" ]] && return is insufficient and should be probably something like # without USE_DHCLIENT there is no dhclient binary in the recovery system # so that networking setup via DHCP is not possible: test "$USE_DHCLIENT" || return # with USE_STATIC_NETWORKING no networking setup via DHCP must happen # see default.conf: USE_STATIC_NETWORKING overrules USE_DHCLIENT test "$USE_STATIC_NETWORKING" && return |
|
@gdha I added you here because I think you implemented |
This is exactly what this patch is doing ;-). You have DHCP client bin in your recovery system it is just not executed. I can only agree that it makes more sense to put it into 58-start-dhclient.sh, will correct it ... |
|
I do not undrestand how with your initial commit via if [[ ! -z "$USE_DHCLIENT" && -z "$USE_STATIC_NETWORKING" ]]; then
REQUIRED_PROGS=( "${REQUIRED_PROGS[@]}" $DHCLIENT_BIN $DHCLIENT6_BIN )
the dhclient binaries get added to the recovery system even for USE_DHCLIENT="yes" USE_STATIC_NETWORKING="yes" |
|
Stupid me! ! -z "$USE_DHCLIENT" && -z "$USE_STATIC_NETWORKING" condition is obviously already too complicated for me |
where it makes much more sense.
|
:-) now it should be more readable ... |
In default.conf we have comment:
This is currently not true, because doesn't matter how is USE_STATIC_NETWORKING set, dhcp configuration will be triggered in rear recover.