use BACKUP_PROG_COMPRESS_OPTIONS as an array (issue904) #912
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
I tested it on SLES12 SP1 with tar version 1.27.1 BACKUP_PROG_COMPRESS_OPTIONS=( -I 'gzip -9 -n -c' ) and also without it i.e. using the default BACKUP_PROG_COMPRESS_OPTIONS=( --gzip ) from usr/share/rear/conf/default.conf In case of BACKUP_PROG_COMPRESS_OPTIONS=( -I 'gzip -9 -n -c' ) the backup.log file contains (long line shown wrapped here): ++ tar --warning=no-xdev --sparse --block-number --totals --verbose --no-wildcards-match-slash --one-file-system --ignore-failed-read --anchored -I 'gzip -9 -n -c' -X ... In case of the new default BACKUP_PROG_COMPRESS_OPTIONS=( --gzip ) and also with the old default BACKUP_PROG_COMPRESS_OPTIONS="--gzip" the backup.log file contains (long line shown wrapped here): ++ tar --warning=no-xdev --sparse --block-number --totals --verbose --no-wildcards-match-slash --one-file-system --ignore-failed-read --anchored --gzip -X ... |
Member
Author
|
I don't think there could be regressions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented enhancement #904
BACKUP_PROG_COMPRESS_OPTIONS is now an array
so that one can use it to provide more complex values.
E.g. to override the gzip default compression level (-6)
via the tar '-I' option like
BACKUP_PROG_COMPRESS_OPTIONS=( -I 'gzip -9 -n -c' )
But using it with command options (as in 'gzip -9')
fails with tar versions before 1.27 with a tar error
message like "gzip -9: Cannot exec" because only
since tar version 1.27 tar supports passing command
line arguments to external commands, see
http://git.savannah.gnu.org/cgit/tar.git/plain/NEWS?id=release_1_27