overhauled 05_start_required_daemons.sh #891
Conversation
…e 889), make it no longer fatal when rpc.statd is unavailable (issue 870), removed all references to FD8 (issue 887 and pull request 874), first steps to be prepared for 'set -eu' (rear coding style).
jsmeix
added
enhancement
|
@gdha |
…ng style - now the final check if RPC status service is available is well separated from the result of starting rpc.statd
| # check that RPC portmapper service is available and wait for it as needed | ||
| # on some systems portmap/rpcbind can take some time to be accessible | ||
| # hence 5 attempts each second to check that RPC portmapper service is available | ||
| for attempt in $( seq 5 ) ; do |
There was a problem hiding this comment.
I wonder as you use seq now if this should move from PROGS to REQUIRED_PROGS conf/GNU/Linux.conf?
Or, we could replace it by $(echo 1 2 3 4 5) ?
|
@jsmeix looks good to me; I just left a minor remark in your pull request - it is up to you to modify or ignore - I have no real preference. |
|
Regarding 'seq' usage in current code: sources/rear/github/rear $ find * | xargs grep 'seq ' usr/share/rear/backup/DUPLICITY/default/50_make_duplicity_backup.sh: # for i in $(seq 0 $(($NMBRS - 1)) ) usr/share/rear/lib/layout-functions.sh: for pos in $(seq 0 $(( max -1 ))); do usr/share/rear/lib/network-functions.sh: for j in $(seq $pads); do usr/share/rear/lib/network-functions.sh: for i in $(seq 5); do usr/share/rear/lib/udev-workflow.sh: for i in $(seq 1 15); do usr/share/rear/output/ISO/Linux-i386/81_prepare_multiple_iso.sh:for i in `seq -f '%02g' 1 $(($NB_ISOS-1))`; do usr/share/rear/verify/NETFS/default/05_start_required_daemons.sh:for attempt in $( seq 5 ) ; do I think I better make 'seq' one of the REQUIRED_PROGS. |
|
First test result: RESCUE g130:~ # rear -d -D recover Relax-and-Recover 1.18 / Git Using log file: /var/log/rear/rear-g130.log Starting required daemons for NFS: RPC portmapper (portmap or rpcbind) and rpc.statd if available. Started RPC portmapper 'rpcbind'. RPC portmapper 'rpcbind' available. Started rpc.statd. RPC status rpc.statd available. NOTICE: Will do driver migration ... |
|
Second test result: RESCUE f121:~ # rear -d -D recover /bin/bash: warning: setlocale: LC_ALL: cannot change locale (en_GB.iso885915) Relax-and-Recover 1.18 / Git Using log file: /var/log/rear/rear-f121.log Starting required daemons for NFS: RPC portmapper (portmap or rpcbind) and rpc.statd if available. Started RPC portmapper 'rpcbind'. RPC portmapper 'rpcbind' available. Started rpc.statd. RPC status rpc.statd available. NOTICE: Will do driver migration ... |
|
Hmmm... |
jsmeix
added
fixed / solved / done
and removed
waiting for info
|
I merge it because it works well for me and |
|
For completeness: With usr/share/rear/verify/NETFS/default/05_start_required_daemons.sh |
2 participants
use plain 'rpcinfo -p'
see #889
make it no longer fatal when rpc.statd is unavailable
see #870
removed all references to FD8
see #887
and #874
first steps to be prepared for 'set -eu'
see https://github.com/rear/rear/wiki/Coding-Style