Skip to content

Conversation

@jsmeix
Copy link
Member

@jsmeix jsmeix commented Jun 17, 2016

check if findmnt supports FSROOT (issue883)
and use 'findmnt -m' to make 'fs' entries (issue882)

@jsmeix jsmeix merged commit cd2e9d3 into rear:master Jun 17, 2016
@jsmeix jsmeix added enhancement Adaptions and new features bug The code does not do what it is meant to do fixed / solved / done labels Jun 17, 2016
@jsmeix jsmeix added this to the Rear v1.19 milestone Jun 17, 2016
@jsmeix jsmeix self-assigned this Jun 17, 2016
@jsmeix
Copy link
Member Author

jsmeix commented Jun 17, 2016

I merge it because it still works for me on a SLE12-SP1 system
with its default btrfs structure.

@jsmeix
Copy link
Member Author

jsmeix commented Jun 17, 2016

A few days ago I had learned about a nice (or scaring?)
GitHub function that one can edit files directly via the
GitHub web interface (provided one has write permissions).

Because I only liked to enhance a comment
in 23_filesystem_layout.sh that is output
to disklayout.conf in 23_filesystem_layout.sh
from

echo "# Attributes cannot be determined because no executable 'lsattr' and/or 'findmnt' command(s) found."

to

 echo "# Attributes cannot be determined because no executable 'lsattr' and/or 'findmnt' command(s) found that supports 'FSROOT'."

I dared to do that trivial change directly via the GitHub web interface.

I am impressed how well this is implemented in GitHub.
My direct edit resulted an additional nice git commit
b22ee01
on top of rear master.

@jsmeix jsmeix deleted the check_if_findmnt_supports_FSROOT_issue883 branch July 21, 2016 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug The code does not do what it is meant to do enhancement Adaptions and new features fixed / solved / done

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant