-
-
Notifications
You must be signed in to change notification settings - Fork 268
Typo in install_yaboot.sh with sfdisk command (2>&8 instead of 2>&1) ???? #874
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
After looking at other rear shell, I've seen other references to file descriptor 8 and 7. So I think it is not a typo .... but I prefer asking you for confirmation. |
|
@schabrolles in The use of the progress bar is however not used anymore these days. |
|
@schlomo What shall we do with the progress bar thingy? |
|
If we don't use the progress bar any more then we should also remove all references to FD8, e.g. |
|
There is currently the generic question whereto In particular see #885 (comment) (excerpt): the mkfs commands do not have >&2 appended (I guess that was done on purpose so that the user see something on the screen). Therefore there is also the question here if the sfdisk output Regardless of that question we do no longer use FD8 @schabrolles |
|
@jsmeix |
overhauled 05_start_required_daemons.sh use plain 'rpcinfo -p' see issue #889 make it no longer fatal when rpc.statd is unavailable see isuue #870 removed all references to FD8 see issue #887 and pull request #874 first steps to be prepared for 'set -eu' see https://github.com/rear/rear/wiki/Coding-Style
I'm not sure, but it looks like a typo. Could you check and confirm ?