Skip to content

Conversation

@schabrolles
Copy link
Contributor

I'm not sure, but it looks like a typo. Could you check and confirm ?

@schabrolles schabrolles changed the title Correct typo in install_yaboot.sh with sfdisk command (2>&8 instead of 2>&1) ???? Typo in install_yaboot.sh with sfdisk command (2>&8 instead of 2>&1) ???? Jun 11, 2016
@schabrolles
Copy link
Contributor Author

After looking at other rear shell, I've seen other references to file descriptor 8 and 7. So I think it is not a typo .... but I prefer asking you for confirmation.
Could you tell me why we are using those fd ?
thanks.

@gdha
Copy link
Member

gdha commented Jun 13, 2016

@schabrolles in conf/default.conf you will find some info:

# NOTE: This command will be run within the ProgressBar system !! You should therefore avoid
# output on STDOUT by rerouting that to FD 8, the progress bar
EXTERNAL_CHECK="ssh vms date >&8"

The use of the progress bar is however not used anymore these days.

@gdha
Copy link
Member

gdha commented Jun 20, 2016

@schlomo What shall we do with the progress bar thingy?

@schlomo
Copy link
Member

schlomo commented Jun 20, 2016

If we don't use the progress bar any more then we should also remove all references to FD8, e.g. >&8. The progress bar mechanism would swallow all data.

@jsmeix
Copy link
Member

jsmeix commented Jun 21, 2016

There is currently the generic question whereto
stdout and stderr output should go, see #885

In particular see #885 (comment) (excerpt):

the mkfs commands do not have >&2 appended (I guess that was done on purpose so that the user see something on the screen).

Therefore there is also the question here if the sfdisk output
should tray on stderr or if it should be redirected to stdout
"on purpose so that the user see something on the screen"?

Regardless of that question we do no longer use FD8
so that either "2>&1" or nothing is correct nowadays.

@schabrolles
by the way:
Preferably use $( COMMAND ) instead of backticks,
see https://github.com/rear/rear/wiki/Coding-Style

@schabrolles
Copy link
Contributor Author

@jsmeix
I'm not the original author and also noticed that ... I can add this change to also remove backticks.

@gdha gdha added the enhancement Adaptions and new features label Jun 22, 2016
@gdha gdha added this to the Rear v1.19 milestone Jun 22, 2016
@gdha gdha assigned gdha and jsmeix Jun 22, 2016
@gdha gdha merged commit 8500630 into rear:master Jun 22, 2016
jsmeix added a commit that referenced this pull request Jun 23, 2016
overhauled 05_start_required_daemons.sh


use plain 'rpcinfo -p'
see issue #889

make it no longer fatal when rpc.statd is unavailable
see isuue #870

removed all references to FD8
see issue #887
and pull request #874

first steps to be prepared for 'set -eu'
see https://github.com/rear/rear/wiki/Coding-Style
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement Adaptions and new features

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants