Ignoring block device which are part of a multipath device. #853
+16
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
20_partition_layout.sh gets partition size from /sys/block filesystem for every hdX or sdX device. But if the block device is a path of a multipath device, partition and size information does not exist which stop the script with the following message: "ERROR: BUG BUG BUG! Could not determine size of disk sdb/sdb2, please file a bug. === Issue report === Please report this unexpected issue at: https://github.com/rear/rear/issues Also include the relevant bits from /var/log/rear/rear-XXXXXXXX.log.lockless" To avoid this situation, we test if the sdX or hdX is part of a multipath device. If yes, we ignore it (real multipath device dm-X will be treated further by multipath scripts).
|
|
||
| disktype=$(parted -s $devname print | grep -E "Partition Table|Disk label" | cut -d ":" -f "2" | tr -d " ") | ||
| #Check if blockd is a path of a multipath device. | ||
| if multipath -c /dev/${blockd} > /dev/null 2>&1 ; then |
Member
There was a problem hiding this comment.
This implies that multipath is a required binary for rear! In lots of set-ups multipath is not used. Is there no other way to make this test?
Contributor
Author
There was a problem hiding this comment.
@gdha if multipath is not installed and setup, then the result of multipath -c /dev/${blockd} will not be true; which is good in this case.
So the script will continue by trying to get partition size of /dev/${blockd} etc ..
To make it cleaner, we could test if multipath command is available before. but it will add extra non necessary if condition test.
Tell me what you prefer.
Member
There was a problem hiding this comment.
How about creating a function that abstracts that logic? Could be as simple as
function is_multipath_path {
[ "$1" ] && type multipath &>/dev/null && multipath -c /dev/$1 &>/dev/null
}
* Avoid to use multipath command if this one is not present * Improve code readibility
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
20_partition_layout.shgets partition size from/sys/blockfilesystem for every hdX or sdX device.But if the block device
$blockdis a path of a multipath device, partition and size information does not exist anymore in/sys/blockwhich stop the script with the following message:To avoid this situation, I propose to test if the sdX or hdX (
$blockd) is part of a multipath device.If yes, we ignore it because it will be handled by
28_multipath_layout script(real multipath devicedm-Xwill be treated further by multipath scripts).