Skip to content

Let usr/sbin/rear '-D' automatically also set '-d' and '-v' #1577

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jsmeix merged 1 commit into from
Nov 17, 2017
Merged

Let usr/sbin/rear '-D' automatically also set '-d' and '-v' #1577

jsmeix merged 1 commit into from
Nov 17, 2017

Conversation

@jsmeix
Copy link
Member

@jsmeix jsmeix commented Nov 16, 2017 •
edited
Loading

Let the 'debugscript mode' ( '-D' ) automatically
also set 'debug mode' ( '-d' ) and 'verbose mode' ( '-v' ).

I never use '-D' alone.
When I need the debugscript mode I always also
need debug messages and verbose command output.

Or is there a reason why '-D' alone without
debug messages and verbose command output
actually makes sense?

@jsmeix jsmeix added documentation enhancement Adaptions and new features labels Nov 16, 2017
@jsmeix jsmeix added this to the ReaR v2.3 milestone Nov 16, 2017
@jsmeix jsmeix self-assigned this Nov 16, 2017
@jsmeix jsmeix requested review from gdha and gozora November 16, 2017 12:15
@jsmeix
Copy link
Member Author

jsmeix commented Nov 17, 2017

If there are no objections I would like to merge it today
because I canot imagine that this change could cause
any regression what ReaR actually does.

gdha
gdha approved these changes Nov 17, 2017
View reviewed changes
Copy link
Member

@gdha gdha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jsmeix I'm OK with the changes - please keep in mind that there is no need to edit rear.8 as we can recreate it from rear.8.adoc which is the proper way anyhow

@jsmeix jsmeix merged commit c831895 into rear:master Nov 17, 2017
@jsmeix jsmeix deleted the let_debugscript_mode_automatically_also_set_debug_mode branch November 17, 2017 11:55
@jsmeix
Copy link
Member Author

jsmeix commented Nov 17, 2017

@gdha
I know that doc/rear.8 can be recreate it from doc/rear.8.adoc
but as far as I know that recreation does not happen automatically
so that I preferred to also edit doc/rear.8 in this pull request
to have doc/rear.8 and doc/rear.8.adoc already in sync when
merging it without the need to wait for doc/rear.8 recreation.

Or is perhaps doc/rear.8 somehow automatically recreated?

@gdha
Copy link
Member

gdha commented Nov 17, 2017

@jsmeix if you go in the doc area and type make man it will recreate the man page for you

@jsmeix jsmeix mentioned this pull request Jul 25, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gdha gdha gdha approved these changes

@gozora gozora Awaiting requested review from gozora

Assignees

@jsmeix jsmeix

Labels

documentation enhancement Adaptions and new features fixed / solved / done

Projects

None yet

Milestone

ReaR v2.3

Development

Successfully merging this pull request may close these issues.

2 participants

@jsmeix @gdha