Skip to content

Renumbering (NM becomes NM0) to get more free number space #1053

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jsmeix merged 3 commits into from
Oct 27, 2016
Merged

Renumbering (NM becomes NM0) to get more free number space #1053

jsmeix merged 3 commits into from
Oct 27, 2016

Conversation

@jsmeix
Copy link
Member

@jsmeix jsmeix commented Oct 27, 2016

Get more free number space in particular for user scripts, cf.
#1051 (comment)

Renumbered by ading a trailing 0 so that 12 becomes 120
except 00 which becomes 005 and adapted symlinks
to point again to the right re-numbered scripts.
Cf. #1051

@jsmeix
renumbered by ading a trailing 0 so that 12 becomes 120 except 00 whi…
d8f1571 
…ch becomes 005 and adapted symlinks to point again to the right re-numbered scripts
@jsmeix jsmeix added the cleanup label Oct 27, 2016
@jsmeix jsmeix added this to the Rear v1.20 milestone Oct 27, 2016
@jsmeix jsmeix self-assigned this Oct 27, 2016
@jsmeix jsmeix mentioned this pull request Oct 27, 2016
Closed
@jsmeix
Copy link
Member Author

jsmeix commented Oct 27, 2016

Do not yet merge it.

I need to test it and I like to adapt all texts where
the old script names are used to the new numbering:
"NM_foo_bar.sh" -> "NM0_foo_bar.sh"
"00_blah.sh" -> "005_blah.sh"

@jsmeix
Copy link
Member Author

jsmeix commented Oct 27, 2016

Now the sequence of scripts is even more messed up compared to #1051 (comment)

Since there are now three digits used (instead of two)
I also need to fix the way how the sequence of scripts
is generated...

Incredible how fragile all that is...

Impressive that it works at all ...

jsmeix added 2 commits October 27, 2016 16:35
@jsmeix
fixed framework-functions.sh for scripts with the new 3-number digits…
f149cb0 
… (instead of two before) and fixed a lot of texts but the latter is not yet finished see #1053
@jsmeix
fixed the texts to the new 3-number digits of thge scripts where poss…
38131ce 
…ible see #1053
@jsmeix
Copy link
Member Author

jsmeix commented Oct 27, 2016

I verified that the sequence of scripts is the same
before and after renumbering for "rear mkbackup -s"
and "rear recover -s" with BACKUP=NETFS.

I tested "rear mkbackup" and "rear recover"
with BACKUP=NETFS on my SLES12-SP2 system
and it still works for me.

Because I changed all scripts (all got at least a new number)
I will merge it now to avoid conflicts with further work.

@jsmeix jsmeix merged commit 2c12a52 into rear:master Oct 27, 2016
This was referenced Oct 27, 2016
Merged
Closed
@schlomo
Copy link
Member

schlomo commented Oct 27, 2016

Brilliant idea, thanks a lot!

Am 27.10.2016 12:48 nachm. schrieb "Johannes Meixner" <
[email protected]>:

Get more free number space in particular for user scripts, cf.
#1051 (comment)
#1051 (comment)

Renumbered by ading a trailing 0 so that 12 becomes 120
except 00 which becomes 005 and adapted symlinks
to point again to the right re-numbered scripts.

Cf. #1051 #1051

You can view, comment on, or merge this pull request online at:

#1053
Commit Summary

  • renumbered by ading a trailing 0 so that 12 becomes 120 except 00
    which becomes 005 and adapted symlinks to point again to the right
    re-numbered scripts

File Changes

Patch Links:

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
#1053, or mute the thread
https://github.com/notifications/unsubscribe-auth/AAGMCIoYR2jLo20p2KoBUznFSgLSliEqks5q4IGVgaJpZM4KiNCw
.

@jsmeix jsmeix mentioned this pull request Oct 27, 2016
Closed
@jsmeix
Copy link
Member Author

jsmeix commented Oct 27, 2016

@schlomo
very many thanks for your positive feedback!

I was in fear my re-numbering causes more
pain and annoyance than it is actually worth.

But I also think we really needed more free space
in the numbering to be future-proof for some time.

@schlomo
Copy link
Member

schlomo commented Oct 27, 2016

We should just make it very clear in the release notes that existing custom
scripts need to be adapted to the new numbering scheme.

Since this is somewhat a breaking change maybe it is worth bumping the
major version number, too? Or at least abort with an error if NN_*.sh files
are found?

I think increasing the major version number on a regular base would also
signal more development happening :-)

On 27 October 2016 at 19:53, Johannes Meixner [email protected]
wrote:

@schlomo https://github.com/schlomo
very many thanks for your positive feedback!

I was in fear my re-numbering causes more
pain and annoyance than it is actually worth.

But I also think we really needed more free space
in the numbering to be future-proof for some time.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#1053 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAGMCOlooPrQt7-fAewY8D4qKLxU_evuks5q4OUHgaJpZM4KiNCw
.

@jsmeix
Copy link
Member Author

jsmeix commented Oct 28, 2016

@schlomo
I like the general idea of a major version bump.

@gdha
what do you think about using FOSDEM to introduce
a new Relax-and-Recover major version?

According to the "Milestone" dates here "Rear v1.20" is
planned end of December 2016.

Perhaps it is better to skip that and have a
"Relax-and-Recover v 2.0" at FOSDEM 2017
(e.g. end of January just before FOSDEM)?

@jsmeix
Copy link
Member Author

jsmeix commented Oct 28, 2016

I will implement an error if NN_*.sh files are found.

I may try to implement an error if files starting with digits
are found that do not match the NNN_ scheme.

@schlomo
Copy link
Member

schlomo commented Oct 29, 2016

Since people are usually wary of a X.0 version I would suggest to do the
2.0 release sooner and then have a 2.1 or 2.2 ready for FOSDEM :-)

On 28 October 2016 at 10:01, Johannes Meixner [email protected]
wrote:

I will implement an error if NN_*.sh files are found.

I may try to implement an error if files starting with digits
are found that do not match the NNN_ scheme.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#1053 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAGMCCjKa9dXYWDQMZObhjamvQPvUc1lks5q4avfgaJpZM4KiNCw
.

gdha added a commit that referenced this pull request Jan 4, 2017
@gdha
Seems usr/share/rear/verify/EXTERNAL/default/050_check_external.sh wa…
df8c92a 
…s lost somehow during the renumbering task (I guess),

but I think it is still  a valid script to keep (in prep it is still there I noticed).
Related to issue #1053
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@gdha gdha

@jsmeix jsmeix

Labels

cleanup fixed / solved / done

Projects

None yet

Milestone

Rear v1.20

Development

Successfully merging this pull request may close these issues.

3 participants

@jsmeix @schlomo @gdha