Skip to content

Conversation

@gozora
Copy link
Member

@gozora gozora commented Oct 19, 2016

Spelling corrections
BORG_* variables renamed to BORGBACKUP_* to avoid collisions with Borg.
When ReaR uses Borg as back end, it defaults to "none" compression to be aligned with Borg defaults.

BORG_* variables renamed to BORGBACKUP_* to avoid collisions with Borg.
@gdha gdha added this to the Rear v1.20 milestone Oct 20, 2016
@gdha gdha added the enhancement Adaptions and new features label Oct 20, 2016
@gdha gdha merged commit 419d517 into rear:master Oct 20, 2016
@jsmeix
Copy link
Member

jsmeix commented Oct 20, 2016

I have a question:
Now there is is default.conf

BORGBACKUP_COMPRESSION="none"

I assume this enforces "none" compression for rear
regardless what the users may have set in its Borg
configuration (I assume the user can configure
a compression that Borg should use), cf
#1037 (comment)
where I assumed that with an empty
BORG_COMPRESSION=""
the Borg default gets used.

Bottom line: I wonder if

BORGBACKUP_COMPRESSION=""

would be more in compliance with Borg?

@gozora
Copy link
Member Author

gozora commented Oct 20, 2016

@jsmeix , exactly none compression is enforced now. I guess this is not right thing to do :-(.
BORGBACKUP_COMPRESSION="" will not however work as value is appended like this
borg create --compression <BORGBACKUP_COMPRESSION> .. so it would throw syntax error.

I'll think about some way how to solve this.

Thanks for checking!

@gozora
Copy link
Member Author

gozora commented Oct 20, 2016

ehm, not sure if it is clear from above text, but user can change compression setting e.g. BORGBACKUP_COMPRESSION="zlib,9" in local.conf

@jsmeix
Copy link
Member

jsmeix commented Oct 20, 2016

Of course the user can specify what he wants in local.conf
but my point and Thomas Waldmann's point in
#1037 (comment)
is that when the user does not specify anything,
then rear should use Borg in its default mode.

In other words:
When the user does not specify anything in rear,
rear should not specify something special for Borg.

@gozora
Copy link
Member Author

gozora commented Oct 20, 2016

Ok, I'll correct it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement Adaptions and new features fixed / solved / done

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants