Fixed non ASCII characters in scripts. #1024
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
@gdha |
gdha
reviewed
Oct 4, 2016
| # Public License. Refer to the included LICENSE for full text of license. | ||
|
|
||
| if [ "$BACKUP_PROG" = "duply" ] && has_binary duply; then | ||
| if [ "$BACKUP_PROG" = "duply" ] && has_binary duplyi ; then |
Member
Author
There was a problem hiding this comment.
@gdha
you should not look only at the initial commit
(I detected this error and fixed it with my second commit).
Better use the "Files changed" tab at the top because
that shows the resulting changes of all my commits.
jsmeix
deleted the
fix_non_ASCII_characters_in_scripts_related_to_issue1018
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Non-ASCII characters (e.g. UTF-8 characters) in scripts
are not wanted, see
#1018 (comment)
Non-ASCII characters (e.g. UTF-8 characters) in scripts
might even cause failures on systems that do not
support non-POSIX/non-C locales (like UTF-8),
e.g. in the recovery system during "rear recover".
Currently non-ASCII characters were only used in
comments in the scripts but even that makes it at least
hard to read the comments in a non-ASCII locale
in particular because it is impossible to know
what encoding is meant by a sequence of bytes
that is a non-ASCII character, cf.
https://en.opensuse.org/SDB:Plain_Text_versus_Locale