-
-
Notifications
You must be signed in to change notification settings - Fork 268
Pull fixes for partitioning and udev. #1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Partitions on device mapper devices in general do not show up as children of the device in sysfs. Instead, they get their own entry under /sys/block (and only after a partprobe/reboot). That entry lacks a start attribute, so we fall back to the code used during migrations when recreating the partitions.
|
Not sure how we are organizing our workflow, but I am sure I am not going to merge pull requests of everyone :-) |
|
I think it's useful that we also restrict ourselves to "someone else should review these changes" and point out blatant errors... That's open for discussion. |
|
I agree, but I prefer the current practice of sending changes to the list, rather than creating a pull-request (and automatic issue). Not only do you get a much larger audience, people will see the change anytime, while through Github, the first person to merge will make it invisible to the next person. I would keep pull-requests exclusively for the occasional external contributor (and maybe for a large changeset that might be controversial), in all other cases we should be able to push to the master tree like we have been doing. |
Pull fixes for partitioning and udev.
Update 200_prompt_user_to_start_restore.sh
These fixes correspond to svn rev 765 and 766.
Tested on Arch and RHEL5.