Skip to content

Conversation

@jhoekx
Copy link
Contributor

@jhoekx jhoekx commented Feb 16, 2012

These fixes correspond to svn rev 765 and 766.

Tested on Arch and RHEL5.

Partitions on device mapper devices in general do not show up as children of the device in sysfs. Instead, they get their own entry under /sys/block (and only after a partprobe/reboot).

That entry lacks a start attribute, so we fall back to the code used during migrations when recreating the partitions.
@dagwieers
Copy link
Contributor

Not sure how we are organizing our workflow, but I am sure I am not going to merge pull requests of everyone :-)

@jhoekx
Copy link
Contributor Author

jhoekx commented Feb 16, 2012

I think it's useful that we also restrict ourselves to "someone else should review these changes" and point out blatant errors...

That's open for discussion.

@dagwieers
Copy link
Contributor

I agree, but I prefer the current practice of sending changes to the list, rather than creating a pull-request (and automatic issue). Not only do you get a much larger audience, people will see the change anytime, while through Github, the first person to merge will make it invisible to the next person.

I would keep pull-requests exclusively for the occasional external contributor (and maybe for a large changeset that might be controversial), in all other cases we should be able to push to the master tree like we have been doing.

jhoekx added a commit that referenced this pull request Feb 16, 2012
Pull fixes for partitioning and udev.
@jhoekx jhoekx merged commit 2300860 into rear:master Feb 16, 2012
@ghost ghost assigned jhoekx Mar 22, 2012
gdha pushed a commit that referenced this pull request Feb 12, 2015
gdha pushed a commit that referenced this pull request Mar 4, 2015
Update your fork please
gdha pushed a commit that referenced this pull request Aug 29, 2016
@rowswell rowswell mentioned this pull request Sep 25, 2017
rmetrich added a commit to rmetrich/rear that referenced this pull request Nov 14, 2017
rmetrich added a commit to rmetrich/rear that referenced this pull request Nov 14, 2017
rmetrich added a commit to rmetrich/rear that referenced this pull request Nov 28, 2017
gdha pushed a commit that referenced this pull request Jan 6, 2018
Update 200_prompt_user_to_start_restore.sh
rmetrich added a commit to rmetrich/rear that referenced this pull request Jan 9, 2018
jsmeix pushed a commit that referenced this pull request Oct 16, 2019
jsmeix pushed a commit that referenced this pull request Jul 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug The code does not do what it is meant to do

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants