Workaround for RN >= 0.49 metro-bundler check for single string liter…#1346
Merged
Conversation
…al argument to require() (#1342)
kneth
approved these changes
Sep 26, 2017
Contributor
|
although this fixes the issue. The #1332 got a point that we should not be fighting the RN but working with it. These workarounds and node requires work but maybe it's worth investigating how we can remove them since they are workarounds still. @ashwinphatak got a good point that #1332 may introduce a breaking change, but isn't it worth investigating how we can have #1332 in and not introducing the breaking change at the same time. in short this fix just fixes the workaround |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…al argument to require() (#1342)
What, How & Why?
Reference to the issue(s) addressed by this PR: # ???
☑️ ToDos
Breakinglabel has been applied or is not necessaryIf this PR adds or changes public API's: